Add pocl (a CPU OpenCL implementation) #2254
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
inducer
changed the title
|
(Currently missing libcxx. Totally forgot about that, will submit that next.) |
|
libcxx is built, resuming. |
inducer
changed the title
|
@conda-forge/core This is ready for review. It adds an implementation of OpenCL for CPUs. It's LInux-only for the moment, but I am hoping to bring up Mac support over the coming weeks. With this merged, |
| @@ -1,45 +0,0 @@ | |||
| {% set version = "0.1.5" %} | |||
There was a problem hiding this comment.
You don't need / shouldn't remove other recipes from the recipe dir. conda-forge will skip them.
There was a problem hiding this comment.
Whoops, sorry. Fixed.
| - 0001-Fix-clEnqueueFillBuffer-memory-leak.patch | ||
|
|
||
| build: | ||
| number: 4 |
There was a problem hiding this comment.
build number should be zero for new recipes.
There was a problem hiding this comment.
I started this at 4 because I have had a version of this in my own channel, and I want to make sure that the folks who currently use that package have a smooth upgrade path. I'm happy to revert to zero if you think that starting at zero is the overriding concern, but overall I thought, "it's just a number", and figured obvious upgrade behavior from the out-of-tree package was more important than clean numbering. Let me know if you feel strongly about this, I'll revert if you prefer.
There was a problem hiding this comment.
Ahh this makes sense. Thanks for clarifying.
| @@ -57,5 +57,5 @@ find conda-recipes -mindepth 2 -maxdepth 2 -type f -name "yum_requirements.txt" | |||
| | xargs -n1 cat | grep -v -e "^#" -e "^$" | \ | |||
| xargs -r yum install -y | |||
|
|
|||
| conda-build-all /conda-recipes --matrix-conditions "numpy >=1.11" "python >=2.7,<3|>=3.5" | |||
| conda-build-all /conda-recipes --matrix-conditions "numpy >=1.11" "python >=2.7,<3|>=3.5" "r-base >=3.3.2" | |||
There was a problem hiding this comment.
I don't think we should modify the scripts dir in a recipe PR. @conda-forge/core may know more.
There was a problem hiding this comment.
Argh. I didn't meant to. This is a merge of staged-recipes master gone wrong. Fixed, sorry.
|
@scopatz Thanks for the review. I've addressed your concerns. |
|
Thanks! |
No description provided.