Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gocommands package #22556

Merged
merged 20 commits into from
Feb 7, 2024
Merged

Adding gocommands package #22556

merged 20 commits into from
Feb 7, 2024

Conversation

iychoi
Copy link
Contributor

@iychoi iychoi commented Apr 13, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gocommands) and found some lint.

Here's what I've got...

For recipes/gocommands:

  • The license item is expected in the about section.
  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 35]
  • There are too few lines. There should be one empty line at the end of the file.
  • Recipe maintainer "Illyoung Choi" does not exist

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gocommands) and found some lint.

Here's what I've got...

For recipes/gocommands:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 38]
  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gocommands) and found it was in an excellent condition.

@iychoi iychoi force-pushed the gocommands branch 3 times, most recently from cfb5052 to c41feff Compare April 13, 2023 18:41
@iychoi
Copy link
Contributor Author

iychoi commented Apr 21, 2023

@conda-forge/staged-recipes, this package is read for review.

Copy link

stale bot commented Dec 27, 2023

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Dec 27, 2023
Copy link
Member

@carterbox carterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please build the binaries from source instead of repackaging pre-built binaries.

https://conda-forge.org/docs/maintainer/knowledge_base.html#compilers
conda-forge/conda-forge.github.io#1052

@stale stale bot removed the stale will be closed in 30 days label Dec 27, 2023
recipes/gocommands/LICENSE Outdated Show resolved Hide resolved
recipes/gocommands/meta.yaml Outdated Show resolved Hide resolved
recipes/gocommands/meta.yaml Show resolved Hide resolved
recipes/gocommands/meta.yaml Outdated Show resolved Hide resolved
recipes/gocommands/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gocommands) and found some lint.

Here's what I've got...

For recipes/gocommands:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].

@iychoi iychoi force-pushed the gocommands branch 4 times, most recently from b6ca096 to f776db4 Compare January 16, 2024 22:38
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gocommands) and found it was in an excellent condition.

@iychoi
Copy link
Contributor Author

iychoi commented Jan 16, 2024

@xhochy @carterbox I reworked the recipe to build the binary from source. Can you review it again?

@iychoi
Copy link
Contributor Author

iychoi commented Jan 26, 2024

The certificate issue is probably something to do with the Windows VM provided by Azure, not us. Please try updating this branch, there may be a fix on staged-recipes/main.

I updated the branch, but it didn't fix the issue.

@iychoi
Copy link
Contributor Author

iychoi commented Jan 26, 2024

Include the licenses of dependencies using "go-licenses".

Skip building on Windows

Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@xhochy xhochy merged commit e16f3ee into conda-forge:main Feb 7, 2024
5 checks passed
@iychoi iychoi deleted the gocommands branch February 8, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants