Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial gw-sklearn-xarray #22655

Merged
merged 10 commits into from
Apr 26, 2023
Merged

initial gw-sklearn-xarray #22655

merged 10 commits into from
Apr 26, 2023

Conversation

mmann1123
Copy link
Contributor

@mmann1123 mmann1123 commented Apr 21, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gw-sklearn-xarray) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gw-sklearn-xarray) and found some lint.

Here's what I've got...

For recipes/gw-sklearn-xarray:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gw-sklearn-xarray) and found it was in an excellent condition.

@mmann1123
Copy link
Contributor Author

@conda-forge/help-python recipe has passed all checks and is ready for review. Thank You.

@jgrss
Copy link

jgrss commented Apr 25, 2023

I am OK with being a maintainer of this sklearn-xarray fork.

recipes/gw-sklearn-xarray/meta.yaml Outdated Show resolved Hide resolved
recipes/gw-sklearn-xarray/meta.yaml Outdated Show resolved Hide resolved
recipes/gw-sklearn-xarray/meta.yaml Outdated Show resolved Hide resolved
mmann1123 and others added 2 commits April 25, 2023 16:21
@mmann1123
Copy link
Contributor Author

@dopplershift New to all this (gh review), thinking I resolved all your comments, anything I need to do on my end other than wait for approval?

Copy link
Contributor Author

@mmann1123 mmann1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dopplershift dopplershift merged commit af9ad7d into conda-forge:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants