Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding xsocs Python application #22705

Merged
merged 5 commits into from Jan 2, 2024
Merged

Adding xsocs Python application #22705

merged 5 commits into from Jan 2, 2024

Conversation

t20100
Copy link
Contributor

@t20100 t20100 commented Apr 27, 2023

This PR adds the xsocs pure Python package.

This recipe provides both xsocs-base and xsocs since the later relies on pyqt while the former can be used without the GUI part.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/xsocs) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/xsocs:

  • It looks like the 'xsocs' output doesn't have any tests.
  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@t20100
Copy link
Contributor Author

t20100 commented Apr 27, 2023

I agree to be listed here as a maintainer.

@t20100
Copy link
Contributor Author

t20100 commented Apr 27, 2023

@conda-forge/help-python, ready for review!

pyqt + matplotlib-base and silx are enough (and it spares matplotlib's tornado dependency)
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/xsocs) and found it was in an excellent condition.

@t20100
Copy link
Contributor Author

t20100 commented May 3, 2023

Addressed suggestions from linting.

Copy link

stale bot commented Dec 31, 2023

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Dec 31, 2023
@carterbox carterbox closed this Jan 2, 2024
@carterbox carterbox reopened this Jan 2, 2024
recipes/xsocs/meta.yaml Outdated Show resolved Hide resolved
recipes/xsocs/meta.yaml Show resolved Hide resolved
recipes/xsocs/meta.yaml Outdated Show resolved Hide resolved
recipes/xsocs/meta.yaml Show resolved Hide resolved
@carterbox carterbox merged commit 201b469 into conda-forge:main Jan 2, 2024
2 of 4 checks passed
@t20100 t20100 deleted the xsocs branch January 8, 2024 09:40
@t20100
Copy link
Contributor Author

t20100 commented Jan 8, 2024

@carterbox thanks for the review and the improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python review-requested stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

None yet

2 participants