Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solara and solara-assets packages #22935

Closed
wants to merge 8 commits into from
Closed

Conversation

giswqs
Copy link
Member

@giswqs giswqs commented May 27, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

widgetti/solara#105

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/solara, recipes/solara-assets) and found some lint.

Here's what I've got...

For recipes/solara:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/solara-assets:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/solara, recipes/solara-assets) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/flit-core, recipes/solara, recipes/solara-assets) and found some lint.

Here's what I've got...

For recipes/flit-core:

  • The home item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flit-core, recipes/solara, recipes/solara-assets) and found it was in an excellent condition.

@giswqs
Copy link
Member Author

giswqs commented May 27, 2023

@conda-forge/help-python The recipes are ready for review. Thank you.

@maartenbreddels
Copy link
Contributor

Great work @giswqs !
solara and solara-assets are always released together (with the same version number) and pinned to each other.
Would it be possible to have 1 recipe that will release both?
In my experience, releasing 2 separate packages on conda-forge with an interdependency is not great because it takes a few hours before the new release is seen. So you have to wait first, edit the recipe, then make sure CI is run again.

I tried to do something with voila once conda-forge/voila-feedstock#51

@luk-f-a
Copy link

luk-f-a commented May 27, 2023

I don't have any experience with conda-forge, but reading the docs it might be possible, https://conda-forge.org/docs/maintainer/adding_pkgs.html#adding-multiple-packages-at-once

@@ -0,0 +1,42 @@
{% set name = "flit-core" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flit-core is provided by flit-feedstock multi-output recipe, which also demonstrates how solora(-assets) can be built in the same meta.yaml. All feedstocks -> packages can be seen on https://conda-forge.org/feedstock-outputs/

@maartenbreddels maartenbreddels mentioned this pull request Jul 20, 2023
10 tasks
@dhirschfeld
Copy link
Member

dhirschfeld commented Jul 22, 2023

I missed this PR so ended up putting in one of my own - #23413.

That has been merged so now solara and solara-assets are being built from https://github.com/conda-forge/solara-feedstock:

❯ mamba search 'solara*'
Getting repodata from channels...

conda-forge/noarch                                  11.8MB @   9.9MB/s  1.2s
conda-forge/linux-64                                29.3MB @   5.2MB/s  5.7s


 Name          Version Build        Channel
────────────────────────────────────────────────
 solara        1.19.0  pyhd8ed1ab_0 conda-forge
 solara-assets 1.19.0  pyh1a96a4e_0 conda-forge

Feel free to open an issue if you'd like to be added as a maintainer.

@giswqs
Copy link
Member Author

giswqs commented Jul 22, 2023

Awesome! Closing this one.

@giswqs giswqs closed this Jul 22, 2023
@giswqs giswqs deleted the solara branch July 31, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants