Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ipyreact #22993

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Add ipyreact #22993

merged 3 commits into from
Jun 2, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 2, 2023 •
edited
Loading

Generated with grayskull.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ipyreact) and found it was in an excellent condition.

@martinRenou martinRenou mentioned this pull request Jun 2, 2023
Open
jtpio
jtpio commented Jun 2, 2023
View reviewed changes
recipes/ipyreact/meta.yaml Outdated
Comment on lines 45 to 46
- maartenbreddels
- kolibril13
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @maartenbreddels @kolibril13 do you agree to be listed as maintainers here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add me? 🙏🏽

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm forced now 😄

@jtpio jtpio marked this pull request as ready for review June 2, 2023 07:57
@jtpio
Copy link
Member Author

jtpio commented Jun 2, 2023

@conda-forge/help-python this is ready for review, thanks!

martinRenou
martinRenou approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wolfv wolfv merged commit e52b34c into conda-forge:main Jun 2, 2023
5 checks passed
@jtpio jtpio deleted the ipyreact branch June 2, 2023 12:57
@kylebarron kylebarron mentioned this pull request Mar 15, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maartenbreddels maartenbreddels maartenbreddels left review comments

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
python review-requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtpio @maartenbreddels @martinRenou @wolfv