-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Neuralprophet recipe #23383
Add Neuralprophet recipe #23383
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/neuralprophet:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/neuralprophet:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please ping conda-forge/help-python ready to review! |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/help-python and so here I am doing that. |
recipes/neuralprophet/meta.yaml
Outdated
imports: | ||
- neuralprophet | ||
commands: | ||
- pip check || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for that. Pip check will fail properly in the CI with a nice message.
- pip check || true | |
- pip check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip check fails because of another library called dash. I asked in the gitter and they said to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why but I'd rather comment out the test, b/c it is just not working in this case, and add a comment on why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok cool thanks
MIT_LICENSE.txt
Outdated
@@ -0,0 +1,7 @@ | |||
Copyright (c) 2015-2023, MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not in the recipe directory. Do you need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there other steps I need to take now that the pr is merged?
Co-authored-by: Filipe <ocefpaf@gmail.com>
Co-authored-by: Filipe <ocefpaf@gmail.com>
@ocefpaf are there other steps I have to take to download from conda forge |
Wait ~40 minutes for the feedstock creation and CDN sync. Then you can install it from the conda-forge channel. You can read more in https://conda-forge.org/docs/maintainer/adding_pkgs.html#post-staging-process and https://conda-forge.org/docs/user/introduction.html#how-can-i-install-packages-from-conda-forge |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).