Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Neuralprophet recipe #23383

Merged
merged 17 commits into from
Jul 21, 2023
Merged

Add Neuralprophet recipe #23383

merged 17 commits into from
Jul 21, 2023

Conversation

VaTupuri
Copy link
Contributor

@VaTupuri VaTupuri commented Jul 18, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/neuralprophet) and found some lint.

Here's what I've got...

For recipes/neuralprophet:

  • The home item is expected in the about section.
  • Recipe maintainer "AddYourGitHubIdHere" does not exist

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/neuralprophet) and found some lint.

Here's what I've got...

For recipes/neuralprophet:

  • The home item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/neuralprophet) and found it was in an excellent condition.

@VaTupuri VaTupuri changed the title Neuralprophet Add Neuralprophet package Jul 18, 2023
@VaTupuri
Copy link
Contributor Author

@conda-forge-admin, please ping conda-forge/help-python

ready to review!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

@VaTupuri VaTupuri changed the title Add Neuralprophet package Add Neuralprophet recipe Jul 19, 2023
.ci_support/osx64.yaml Outdated Show resolved Hide resolved
imports:
- neuralprophet
commands:
- pip check || true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for that. Pip check will fail properly in the CI with a nice message.

Suggested change
- pip check || true
- pip check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip check fails because of another library called dash. I asked in the gitter and they said to do this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why but I'd rather comment out the test, b/c it is just not working in this case, and add a comment on why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok cool thanks

MIT_LICENSE.txt Outdated
@@ -0,0 +1,7 @@
Copyright (c) 2015-2023, MIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not in the recipe directory. Do you need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there other steps I need to take now that the pr is merged?

VaTupuri and others added 2 commits July 21, 2023 11:41
VaTupuri and others added 2 commits July 21, 2023 11:44
Co-authored-by: Filipe <ocefpaf@gmail.com>
@ocefpaf ocefpaf merged commit 4fcdb02 into conda-forge:main Jul 21, 2023
5 checks passed
@VaTupuri
Copy link
Contributor Author

@ocefpaf are there other steps I have to take to download from conda forge

@ocefpaf
Copy link
Member

ocefpaf commented Jul 21, 2023

@ocefpaf are there other steps I have to take to download from conda forge

Wait ~40 minutes for the feedstock creation and CDN sync. Then you can install it from the conda-forge channel. You can read more in https://conda-forge.org/docs/maintainer/adding_pkgs.html#post-staging-process and https://conda-forge.org/docs/user/introduction.html#how-can-i-install-packages-from-conda-forge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants