Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add r-quickjsr. #23944

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Add r-quickjsr. #23944

merged 7 commits into from
Jan 17, 2024

Conversation

cbrueffer
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-quickjsr) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-quickjsr) and found some lint.

Here's what I've got...

For recipes/r-quickjsr:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@mfansler
Copy link
Member

@conda-forge/help-c-cpp having same issue here (as in r-stanheaders): clang can't find clock_gettime() on osx-64 despite -std=gnu11. Thanks in advance for any insight!

@mfansler
Copy link
Member

@conda-forge/help-r this should be good now if anyone else wants to review.

Extra license follows how python-quickjs-feedstock handled the Python wrapper. Perhaps at some point we should spin off a quickjs and link against that, but right now this has been blocking RStan builds for several months and would like to prioritize getting those building again.

@github-actions github-actions bot added the R label Jan 14, 2024
@mfansler mfansler merged commit 2fbd229 into conda-forge:main Jan 17, 2024
4 of 5 checks passed
@cbrueffer
Copy link
Member Author

Thanks @mfansler !

@cbrueffer cbrueffer deleted the quickjsr branch January 18, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants