Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for ribasim #24397

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Add recipe for ribasim #24397

merged 6 commits into from
Nov 3, 2023

Conversation

Hofer-Julian
Copy link
Contributor

@Hofer-Julian Hofer-Julian commented Nov 1, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ribasim) and found some lint.

Here's what I've got...

For recipes/ribasim:

  • requirements: run: pydantic=1 must contain a space between the name and the pin, i.e. pydantic =1
  • requirements: run: shapely>=2.0 must contain a space between the name and the pin, i.e. shapely >=2.0
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/ribasim:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ribasim) and found some lint.

Here's what I've got...

For recipes/ribasim:

  • Invalid noarch value python >=3.10. Should be one of python, generic.

For recipes/ribasim:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ribasim) and found it was in an excellent condition.

@Hofer-Julian Hofer-Julian marked this pull request as draft November 1, 2023 08:26
@visr
Copy link
Contributor

visr commented Nov 1, 2023

I approve to become a maintainer.

@Huite
Copy link
Contributor

Huite commented Nov 2, 2023

I approve to be a maintainer.

@Hofer-Julian Hofer-Julian marked this pull request as ready for review November 2, 2023 14:37
@Hofer-Julian
Copy link
Contributor Author

@conda-forge/help-python, ready for review!

@@ -0,0 +1,79 @@
# Note: there are many handy hints in comments in this example -- remove them when you've finalized your recipe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nudge.

Removed the comments and followed closer what grayskull produces

- pandas <2.1
- pandera !=0.16.0
- pyarrow
- pydantic =1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata says it should be:

Suggested change
- pydantic =1
- pydantic >=1.0,<2.dev0

Can you confirm?

This comment was marked as outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I had that originally and it couldn't find a suitable dependency. I think the converter from setuptools metadata has a subtle bug, since it works fine when installing from pypi.

@ocefpaf ocefpaf merged commit 6eace8a into conda-forge:main Nov 3, 2023
5 checks passed
@Hofer-Julian
Copy link
Contributor Author

Thanks for reviewing @ocefpaf!

@Hofer-Julian Hofer-Julian deleted the ribasim branch November 3, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants