-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for ribasim
#24397
Add recipe for ribasim
#24397
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/ribasim:
For recipes/ribasim:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/ribasim:
For recipes/ribasim:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I approve to become a maintainer. |
I approve to be a maintainer. |
@conda-forge/help-python, ready for review! |
recipes/ribasim/meta.yaml
Outdated
@@ -0,0 +1,79 @@ | |||
# Note: there are many handy hints in comments in this example -- remove them when you've finalized your recipe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nudge.
Removed the comments and followed closer what grayskull produces
- pandas <2.1 | ||
- pandera !=0.16.0 | ||
- pyarrow | ||
- pydantic =1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metadata says it should be:
- pydantic =1 | |
- pydantic >=1.0,<2.dev0 |
Can you confirm?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I had that originally and it couldn't find a suitable dependency. I think the converter from setuptools metadata has a subtle bug, since it works fine when installing from pypi.
Thanks for reviewing @ocefpaf! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).