Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ethos_penalps recipe #24405

Merged
merged 9 commits into from
Nov 2, 2023
Merged

Add ethos_penalps recipe #24405

merged 9 commits into from
Nov 2, 2023

Conversation

julian-belina
Copy link
Contributor

@julian-belina julian-belina commented Nov 1, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ethos_penalps) and found some lint.

Here's what I've got...

For recipes/ethos_penalps:

  • There are 1 too many lines. There should be one empty line at the end of the file.
  • requirements: run: numpy < 1.24.0 should not contain a space between relational operator and the version, i.e. numpy <1.24.0
  • requirements: run: sqlalchemy < 2.0 should not contain a space between relational operator and the version, i.e. sqlalchemy <2.0

For recipes/ethos_penalps:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ethos_penalps) and found some lint.

Here's what I've got...

For recipes/ethos_penalps:

  • There are too few lines. There should be one empty line at the end of the file.
  • requirements: host: python>=3.10 must contain a space between the name and the pin, i.e. python >=3.10
  • requirements: host: setuptools>64.0.0 must contain a space between the name and the pin, i.e. setuptools >64.0.0
  • requirements: run: python>=3.10 must contain a space between the name and the pin, i.e. python >=3.10
  • requirements: run: numpy<1.24.0 must contain a space between the name and the pin, i.e. numpy <1.24.0
  • requirements: run: sqlalchemy<2.0 must contain a space between the name and the pin, i.e. sqlalchemy <2.0
  • requirements: run: pip>=21.3 must contain a space between the name and the pin, i.e. pip >=21.3
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/ethos_penalps:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ethos_penalps) and found some lint.

Here's what I've got...

For recipes/ethos_penalps:

  • There are too few lines. There should be one empty line at the end of the file.

For recipes/ethos_penalps:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ethos_penalps) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/ethos_penalps:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ethos_penalps) and found it was in an excellent condition.

@julian-belina
Copy link
Contributor Author

@conda-forge/help-python please review and merge my recipe

@ocefpaf ocefpaf merged commit 76f06dc into conda-forge:main Nov 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants