Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require pygithub 2.1.1 and use timezone aware 'now' #24488

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

jaimergp
Copy link
Member

Fixes errors in scheduled runs.

PyGithub 2.1.0 "fixed" their datetimes by making them UTC aware. But our code was using UTC naive timestamps, so now we have to make them match.

While PyGithub 2.1 has been out for a bit, this only started failing 3 days ago with the introduction of a new conda-smithy that no longer pins pygithub <2, but instead requires >=2,<3.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@isuruf isuruf merged commit f1d9bcb into conda-forge:main Nov 13, 2023
4 of 5 checks passed
@isuruf
Copy link
Member

isuruf commented Nov 13, 2023

Thanks

@@ -41,10 +41,10 @@ mamba install --yes --quiet \
"conda-smithy>=3.7.1,<4.0.0a0" \
conda-forge-pinning \
"conda-build>=3.16" \
"gitpython>=3.0.8" \
"gitpython>=3.0.8,<3.1.20"" \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agh, typo here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #24489

@jaimergp jaimergp mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants