-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ensmallen dependencies #24682
Add ensmallen dependencies #24682
Conversation
@conda-forge-admin, lint |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/jaro-winkler:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/jaro-winkler:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cache_decorator:
For recipes/compress_json:
For recipes/deflate_dict:
For recipes/dict_hash:
For recipes/downloaders:
For recipes/environments_utils:
For recipes/jaro-winkler:
For recipes/support_developer:
For recipes/userinput:
For recipes/validate_version_code:
|
@dillonroach, can you comment here that you are willing to be a maintainer? |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cache_decorator:
For recipes/compress_json:
For recipes/deflate_dict:
For recipes/dict_hash:
For recipes/downloaders:
For recipes/environments_utils:
For recipes/jaro-winkler:
For recipes/support_developer:
For recipes/userinput:
For recipes/validate_version_code:
|
@isuruf - absolutely, thanks - I am willing to be a maintainer |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python, this is ready for a review |
recipes/jaro-winkler/meta.yaml
Outdated
version: {{ version }} | ||
|
||
source: | ||
url: https://pypi.io/packages/py3/j/jaro-winkler/jaro_winkler-{{ version }}-py3-none-any.whl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance to get this one built from the source instead of repacking the wheel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They don't have an sdist. That's why I used the noarch wheel. I could try to use the github source, but I thought the wheel would be better since it's from PyPI. I don't have a preference. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always inclined to build from source. Sure, when it is a pure wheel that is kind of moot. If you don't mind let's use the GH source instead. If that is too much hassle, leave it be and let me know when this is ready for merging.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).cc @dillonroach
Related PRs/issues