Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add serapis package #24897

Merged
merged 23 commits into from
Jan 11, 2024
Merged

add serapis package #24897

merged 23 commits into from
Jan 11, 2024

Conversation

MAfarrag
Copy link
Member

@MAfarrag MAfarrag commented Jan 2, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link

github-actions bot commented Jan 2, 2024

Hi! Thanks for your contribution to conda-forge.
Unfortunately, the recipe was added directly in the recipes folder without its own subfolder.
Please move the recipe file into a folder with the name of the package you want to submit.

For example: if your recipe is currently under recipes/<your_package>.yaml, it should be moved to recipes/<your_package>/meta.yaml.
Thanks!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes) and found some lint.

Here's what I've got...

For recipes:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

For recipes:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

Copy link

github-actions bot commented Jan 2, 2024

Hi! Thanks for your contribution to conda-forge.
Unfortunately, the recipe was added directly in the recipes folder without its own subfolder.
Please move the recipe file into a folder with the name of the package you want to submit.

For example: if your recipe is currently under recipes/<your_package>.yaml, it should be moved to recipes/<your_package>/meta.yaml.
Thanks!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes) and found some lint.

Here's what I've got...

For recipes:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

Copy link

github-actions bot commented Jan 2, 2024

Hi! Thanks for your contribution to conda-forge.
Unfortunately, the recipe was added directly in the recipes folder without its own subfolder.
Please move the recipe file into a folder with the name of the package you want to submit.

For example: if your recipe is currently under recipes/<your_package>.yaml, it should be moved to recipes/<your_package>/meta.yaml.
Thanks!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/serapis) and found it was in an excellent condition.

@MAfarrag
Copy link
Member Author

MAfarrag commented Jan 2, 2024

@conda-forge/python @conda-forge/core can you please check the Windows build can not install mamba for some reason.

@MAfarrag
Copy link
Member Author

MAfarrag commented Jan 3, 2024

@conda-forge/help-python @conda-forge/python can you check, ready for review ?

@ocefpaf
Copy link
Member

ocefpaf commented Jan 5, 2024

Please don't remove existing recipes. Just add yours in the PR.

@MAfarrag
Copy link
Member Author

@ocefpaf @conda-forge/python @conda-forge/help-python please check, ready for review.

Comment on lines 43 to 51
home: https://github.com/MAfarrag/HAPI
license: BSD-3-Clause
license_file: LICENSE.md
license_family: BSD
license_file: LICENSE.md
summary: Flood modelling package
description: |
This module builds hydrodynamic model.
dev_url: https://github.com/Serapieum-of-alex/Serapis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about the home and dev_url here. They are not the same and both are GitHub repos. Also, the license is not correct, both repos report GPL-3 but you are listing here as BSD and you added and MIT file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf corrected

@ocefpaf
Copy link
Member

ocefpaf commented Jan 11, 2024

Can you rebase or, if that is a problem for you, re-submit in a clean PR? You are still removing a file here.

@MAfarrag
Copy link
Member Author

MAfarrag commented Jan 11, 2024

Can you rebase or, if that is a problem for you, re-submit in a clean PR? You are still removing a file here.
@ocefpaf
well i did not delete it was added in the upstream, and i just pressed update.
So can you please merge it now before anything else is updated in the upstream ?

recipes/serapis/meta.yaml Outdated Show resolved Hide resolved
recipes/serapis/meta.yaml Outdated Show resolved Hide resolved
@MAfarrag
Copy link
Member Author

@ocefpaf can you check now ?

recipes/serapis/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Filipe <ocefpaf@gmail.com>
recipes/serapis/LICENSE.md Outdated Show resolved Hide resolved
@MAfarrag
Copy link
Member Author

@ocefpaf anything else ?

@ocefpaf ocefpaf merged commit 3500a1a into conda-forge:main Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants