-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add serapis package #24897
add serapis package #24897
Conversation
Hi! Thanks for your contribution to conda-forge. For example: if your recipe is currently under |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes:
For recipes:
|
Hi! Thanks for your contribution to conda-forge. For example: if your recipe is currently under |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes:
|
Hi! Thanks for your contribution to conda-forge. For example: if your recipe is currently under |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but couldn't find any. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/python @conda-forge/core can you please check the Windows build can not install mamba for some reason. |
@conda-forge/help-python @conda-forge/python can you check, ready for review ? |
Please don't remove existing recipes. Just add yours in the PR. |
@ocefpaf @conda-forge/python @conda-forge/help-python please check, ready for review. |
recipes/serapis/meta.yaml
Outdated
home: https://github.com/MAfarrag/HAPI | ||
license: BSD-3-Clause | ||
license_file: LICENSE.md | ||
license_family: BSD | ||
license_file: LICENSE.md | ||
summary: Flood modelling package | ||
description: | | ||
This module builds hydrodynamic model. | ||
dev_url: https://github.com/Serapieum-of-alex/Serapis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused about the home and dev_url here. They are not the same and both are GitHub repos. Also, the license is not correct, both repos report GPL-3 but you are listing here as BSD and you added and MIT file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocefpaf corrected
Can you rebase or, if that is a problem for you, re-submit in a clean PR? You are still removing a file here. |
|
@ocefpaf can you check now ? |
Co-authored-by: Filipe <ocefpaf@gmail.com>
@ocefpaf anything else ? |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).