Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding compas_timber recipe #25141

Merged
merged 11 commits into from
Feb 13, 2024
Merged

Adding compas_timber recipe #25141

merged 11 commits into from
Feb 13, 2024

Conversation

chenkasirer
Copy link
Contributor

@chenkasirer chenkasirer commented Jan 25, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/compas_timber) and found it was in an excellent condition.

Copy link

Hi! Thanks for your contribution to conda-forge.
When submitting a pull request, please do not change anything in the example recipe.
Please make sure that any changes are reverted before you submit it for review.
Thanks!

Copy link

github-actions bot commented Feb 2, 2024

Hi! Thanks for your contribution to conda-forge.
When submitting a pull request, please do not change anything in the example recipe.
Please make sure that any changes are reverted before you submit it for review.
Thanks!

Copy link

github-actions bot commented Feb 2, 2024

Hi! Thanks for your contribution to conda-forge.
When submitting a pull request, please do not change anything in the example recipe.
Please make sure that any changes are reverted before you submit it for review.
Thanks!

Copy link

github-actions bot commented Feb 2, 2024

Hi! Thanks for your contribution to conda-forge.
When submitting a pull request, please do not change anything in the example recipe.
Please make sure that any changes are reverted before you submit it for review.
Thanks!

@chenkasirer
Copy link
Contributor Author

chenkasirer commented Feb 2, 2024

@conda-forge/help-python ready for review!

Copy link

github-actions bot commented Feb 2, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@chenkasirer
Copy link
Contributor Author

Hi @conda-forge/help-python just kindly pinging again :)

@github-actions github-actions bot added the python label Feb 6, 2024
Copy link

github-actions bot commented Feb 7, 2024

Hi! Thanks for your contribution to conda-forge.
When submitting a pull request, please do not change anything in the example recipe.
Please make sure that any changes are reverted before you submit it for review.
Thanks!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/compas_timber) and found some lint.

Here's what I've got...

For recipes/compas_timber:

  • The following maintainers have not yet confirmed that they are willing to be listed here: gonzalocasas. Please ask them to comment on this PR if they are.

@gonzalocasas
Copy link
Contributor

Yes, I confirm I am willing to be listed here

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/compas_timber) and found it was in an excellent condition.

@gonzalocasas
Copy link
Contributor

@conda-forge/help-python sorry to ping once again, I believe this is ready to review/go, if there's anything wrong or missing, please let us know! Thanks!

@chenkasirer
Copy link
Contributor Author

Per the docs pinging @conda-forge/staged-recipes. Thank you!

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@ocefpaf ocefpaf merged commit 5f37c37 into conda-forge:main Feb 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants