Add LZFSE recipe. #2596
Add LZFSE recipe. #2596
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/lzfse/meta.yaml
Outdated
| # We can't compile c99 lzfse source in VS2008. | ||
| skip: True # [win and py27] | ||
| features: | ||
| - vc14 # [win and py3k] |
There was a problem hiding this comment.
Would recommend not using py3k and using (py35 or py36) as this will probably need to be changed for Python 3.7 anyways.
recipes/lzfse/meta.yaml
Outdated
| build: | ||
| number: 0 | ||
| # We can't compile c99 lzfse source in VS2008. | ||
| skip: True # [win and py27] |
There was a problem hiding this comment.
Would also skip Python 3.5 or 3.6 as they both use the same VC version. So there is no need for both.
recipes/lzfse/meta.yaml
Outdated
|
|
||
| source: | ||
| fn: {{ name }}-{{ version }}.zip | ||
| url: https://github.com/{{ name }}/{{ name }}/archive/{{ ghcommit }}.zip |
There was a problem hiding this comment.
Could we please ask them to tag a release? Just something we can use reliably. Feel free to cc me if you wish.
|
This looks good, but I'd like to see if we can get the developers to weigh in on the release situation. It helps if they can give us some indication of what constitutes a reliable product ready for external user consumption. Unfortunate that they had not done this already. Other than that a couple minor suggestions that should be easy to resolve. Thanks @rolando. |
|
So now that upstream has tagged a version. Could we please update this to use that version? Looks like there are a couple other minor changes to be done. Otherwise LGTM. Am eager to get into a feedstock. |
|
Recipe fixed 🎉 |
|
Added the closes note above. Hope that is ok. |
|
Thanks @rolando. |
Closes #2438
This package has no proper versioning so we start with the last commit version.