Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clojure - WIP: Need third-party licenses from maven #26061

Open
wants to merge 58 commits into
base: main
Choose a base branch
from

Conversation

MementoRC
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clojure) and found it was in an excellent condition.

@MementoRC
Copy link
Contributor Author

This recipe simply installs the pre-built Clojure tool published by the Clojure team and seemingly relying upon the Maven .jar
Building from source seems a bit tricky and more understanding of Clojure/Maven is in progress

The rational for adding this package is that I need it to build Quil, which is needed for QCS. Does this sound useful or an acceptable route for Clojure projects?

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clojure) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/clojure) and found some lint.

Here's what I've got...

For recipes/clojure:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [56]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clojure) and found it was in an excellent condition.

@MementoRC
Copy link
Contributor Author

@conda-forge/help-java Hello, ready for review

@xhochy
Copy link
Member

xhochy commented Apr 29, 2024

As with leinigen: We need the statically bundled third-party licenses for this. There is at least a maven plugin that can produce these lists, but I'm unsure whether it will work here.

@MementoRC
Copy link
Contributor Author

I initially thought I needed clojure to build quil and thought it may be useful clojure devs who wants to work within conda, but I did not, so do you feel that it is a valuable addition to conda-forge?

I can look into the third-party licenses if this package looks useful to conda-forge

@MementoRC MementoRC changed the title Add Clojure Add Clojure - WIP: Need third-party licenses from maven Apr 29, 2024
@xhochy
Copy link
Member

xhochy commented Apr 30, 2024

I cannot state how useful this will be as I'm not familiar with the ecosystem. Other people may need to judge this. In the end, it will need somebody maintaining the recipe to make it really useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants