Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for ZodiPy #26097

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add recipe for ZodiPy #26097

wants to merge 3 commits into from

Conversation

MetinSa
Copy link

@MetinSa MetinSa commented Apr 19, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/zodipy) and found some lint.

Here's what I've got...

For recipes/zodipy:

  • The home item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/zodipy) and found it was in an excellent condition.

@MetinSa
Copy link
Author

MetinSa commented Apr 19, 2024

This PR is to make ZodiPy conform to the pyOpenSci packaging guidelines (see pyOpenSci/software-submission#161).

@MetinSa MetinSa mentioned this pull request Apr 19, 2024
32 tasks
@MetinSa
Copy link
Author

MetinSa commented Apr 19, 2024

@conda-forge/help-python, ready for review!

@lpsinger
Copy link
Contributor

The build is failing due to conda-forge/healpy-feedstock#64.

@dhomeier
Copy link

dhomeier commented Apr 19, 2024

Thanks for the pointer; perhaps @mwcraig can advise?
Another issue is that healpy is not available on Windows, so other packages depending on it have disabled the Windows build, but I am not sure what's the best way to go about this.
Seems other packages depending on healpy are just skipping the build or ignoring failures. ZodiPy is a bit different in that it has a minimum version requirement, but in my macOS miniforge installation conda/mamba indeed identify the healpy version correctly; it's just pip reporting it as 0.0.0.

@MetinSa
Copy link
Author

MetinSa commented Apr 19, 2024

ZodiPy is a bit different in that it has a minimum version requirement, but in my macOS miniforge installation conda/mamba indeed identify the healpy version correctly; it's just pip reporting it as 0.0.0.

I generated the meta.yaml file using grayskull and saw that it set both lower and upper bounds for many of the dependencies. I was not sure if this was required or not by conda-forge, so I didnt change it. I did not set a minimum requirement for healpy in pyproject.toml so i could try to relax this in the meta.yaml file and try again if you think that could help?

@lpsinger
Copy link
Contributor

lpsinger commented Apr 19, 2024

ZodiPy is a bit different in that it has a minimum version requirement, but in my macOS miniforge installation conda/mamba indeed identify the healpy version correctly; it's just pip reporting it as 0.0.0.

I generated the meta.yaml file using grayskull and saw that it set both lower and upper bounds for many of the dependencies. I was not sure if this was required or not by conda-forge, so I didnt change it. I did not set a minimum requirement for healpy in pyproject.toml so i could try to relax this in the meta.yaml file and try again if you think that could help?

One moment. I am looking into the issue with healpy. It would be better if we could fix that bug.

@lpsinger
Copy link
Contributor

One moment. I am looking into the issue with healpy. It would be better if we could fix that bug.

conda-forge/healpy-feedstock#65 should fix it.

@lpsinger
Copy link
Contributor

Fixed. Please try again.

@MetinSa
Copy link
Author

MetinSa commented Apr 20, 2024

The non-windows builds work now, thanks! I am going to see if it still builds with a more relaxed dependency configuration matching thepyproject.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants