Adding conda-pip-minimal package to feedstock

[joshdunnlime]

Checklist

• Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
• License file is packaged (see here for an example).
• Source is from official source.
• Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
• If static libraries are linked in, the license of the static library is packaged.
• Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
• Build number is 0.
• A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
• GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
• When in trouble, please check our knowledge base documentation before pinging a team.

[joshdunnlime]

@conda-forge/help-python

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/conda-pip-minimal) and found some lint.

Here's what I've got...

For recipes/conda-pip-minimal:

• The following maintainers have not yet confirmed that they are willing to be listed here: rxm7706, indigoviolet. Please ask them to comment on this PR if they are.

[rxm7706]

happy to help maintain.

[synapticarbors]

conda-cpm --help should be under commands not requires

[synapticarbors]

If you aren't running the test suite, I don't think you need the source_files. Same goes with pytest under requires

[joshdunnlime]

I would like to run the test suite and plan to add more tests in the next patch. I wanted to get this PR merged first though. Should I keep this as is, remove and add next release or add a simple pytest now?

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conda-pip-minimal) and found it was in an excellent condition.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/conda-pip-minimal) and found some lint.

Here's what I've got...

For recipes/conda-pip-minimal:

• license_file entry is missing, but is required.

[joshdunnlime]

@synapticarbors
I have fixed most of the issues. Will try and get a new version of the package on pypi with the license file distributed as part of the package. If this is not possible, is there a way to add this through staged-recipes?

This python package also needs a "conda-only" dependancy (conda-tree) which is not included in the pypi package. Am I able to add this in addition as shown below?

requirements:
  host:
    - ...
  run:
    - ...
    - ruamel.yaml ~=0.17.21
    - conda-tree >=1.1.0  # e.g. here

Thanks

[synapticarbors]

A few notes:

• If the upstream archive sdist doesn't include the license file, you should add it manually to this recipe. See: https://conda-forge.org/docs/maintainer/adding_pkgs/#packaging-the-license-manually
• All of the requirements that are listed are being pulled from conda-forge, so it's fine to list things that aren't on pypi. Pypi is only used to grab this package's source distribution. So assuming I'm understanding your question correctly, there shouldn't be any issue listing conda-tree among the requirements.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conda-pip-minimal) and found it was in an excellent condition.

[joshdunnlime]

@synapticarbors very clear thanks. This has been actioned. Is this everything done now?

[synapticarbors]

In looking over this again, you need to add the conda-cpm --help to the tests/commands section. It was in the wrong place before and then looks like it was deleted:
https://docs.conda.io/projects/conda-build/en/stable/resources/define-metadata.html#test-commands

If there is something to import then I'd add an import test to:
https://docs.conda.io/projects/conda-build/en/stable/resources/define-metadata.html#python-imports

[joshdunnlime]

This is failing with ModuleNotFoundError: No module named 'conda_pip_minimal'. Do I need to change the entry point from conda-cpm = conda_pip_minimal.cli:app to conda-cpm = conda-pip-minimal.cli:app? This is all I can think it is...

[synapticarbors]

It looks like it's failing on the import test rather than the commands. Strangely, I'm seeing the package in the environment though:
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=921285&view=logs&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823&l=779

[joshdunnlime]

@synapticarbors I've removed the import test for now to try and see if this work with the conda-cpm --help command. I am getting a similar error.

Does my previous comment make more sense now?

This is failing with ModuleNotFoundError: No module named 'conda_pip_minimal'. Do I need to change the entry point from conda-cpm = conda_pip_minimal.cli:app to conda-cpm = conda-pip-minimal.cli:app? This is all I can think it is...