Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Leiningen #26118

Merged
merged 20 commits into from
Jun 13, 2024
Merged

Add Leiningen #26118

merged 20 commits into from
Jun 13, 2024

Conversation

MementoRC
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/leiningen) and found it was in an excellent condition.

@MementoRC
Copy link
Contributor Author

@conda-forge/help-java Hello, ready for review

@xhochy
Copy link
Member

xhochy commented Apr 29, 2024

We need the statically bundled third-party licenses for this. There is at least a maven plugin that can produce these lists, but I'm unsure whether it will work here.

@MementoRC MementoRC changed the title Add Leiningen Add Leiningen - WIP: Need third-party licenses from maven Apr 29, 2024
@MementoRC
Copy link
Contributor Author

This recipe simply installs the standalone JAR. There are licenses in an XML format in most of the packages in the archive, but I think that one does not have a license.

My understanding is that I should build the JAR from source and collect the licenses from the pom.xml. I did try a few times to build from source but failed, then gave up and went the JAR repackaging - Do you think that I am missing/misunderstanding something?

I will come back to this later - currently, I am struggling with zig and getting close to a sbcl linux recipe

@MementoRC MementoRC closed this Jun 11, 2024
@MementoRC MementoRC reopened this Jun 11, 2024
@MementoRC
Copy link
Contributor Author

MementoRC commented Jun 11, 2024

@xhochy This recipe now has the third-party licenses. Since this is a java package, is the noarch: generic correct?
I get the licenses from the source directory pom.xml file, then build the uberjar and install that over the upstream one

@MementoRC MementoRC changed the title Add Leiningen - WIP: Need third-party licenses from maven Add Leiningen Jun 11, 2024
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this so throroughly!

@xhochy xhochy merged commit 0066ce3 into conda-forge:main Jun 13, 2024
5 checks passed
@MementoRC
Copy link
Contributor Author

Very much appreciated

@MementoRC MementoRC deleted the leiningen branch June 13, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants