Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quil #26167

Merged
merged 11 commits into from Apr 30, 2024
Merged

Add Quil #26167

merged 11 commits into from Apr 30, 2024

Conversation

MementoRC
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/quil) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/quil) and found some lint.

Here's what I've got...

For recipes/quil:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [95]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/quil) and found it was in an excellent condition.

@MementoRC
Copy link
Contributor Author

@conda-forge/help-rust Hello, ready for review

recipes/quil/conda_build_config.yaml Outdated Show resolved Hide resolved
recipes/quil/meta.yaml Outdated Show resolved Hide resolved
recipes/quil/meta.yaml Outdated Show resolved Hide resolved
recipes/quil/meta.yaml Outdated Show resolved Hide resolved
recipes/quil/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/quil) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/quil:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [75].

MementoRC and others added 2 commits April 29, 2024 14:17
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/quil) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/quil:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [74].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/quil) and found it was in an excellent condition.

@xhochy xhochy merged commit c421526 into conda-forge:main Apr 30, 2024
5 checks passed
@MementoRC MementoRC deleted the quil branch April 30, 2024 17:00
@MementoRC
Copy link
Contributor Author

@xhochy I forgot to put in the feedstock name reset, can this be done now that the feedstock is live, or is it not a big deal?

@xhochy
Copy link
Member

xhochy commented Apr 30, 2024

We have to live with the repo name. Renaming the repo is a vig deal as it breaks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants