Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C package wmctrl-cli recipe #26256

Merged
merged 41 commits into from
Jun 1, 2024
Merged

Add C package wmctrl-cli recipe #26256

merged 41 commits into from
Jun 1, 2024

Conversation

ehfd
Copy link
Member

@ehfd ehfd commented May 6, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source. - an official versioned source does not exist, so Debian's source tarball was used.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/wmctrl-cli) and found some lint.

Here's what I've got...

For recipes/wmctrl-cli:

  • The build section contained an unexpected subsection name. patches is not a valid subsection name.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/wmctrl-cli) and found it was in an excellent condition.

@ehfd ehfd changed the title Add C package wmctrl recipe Add C package wmctrl-cli recipe May 6, 2024
@ehfd
Copy link
Member Author

ehfd commented May 6, 2024

Notes:

  • This is a package of which Debian, Ubuntu, and other major distros all package officially to this day.
  • However, because this package is so ancient, there is no official GitHub repository. Therefore, Homebrew used the Debian repository tarball as the source. This PR copies the approaches of the Homebrew recipe.
  • The name of this project is originally wmctrl. However, this name (Project has moved to github and fixed Python 3 support wmctrl-feedstock#6 (comment)) is used by the Python wrapper of this CLI. Thus, this feedstock had to be named wmctrl-cli.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/wmctrl-cli) and found some lint.

Here's what I've got...

For recipes/wmctrl-cli:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [28, 37]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/wmctrl-cli) and found it was in an excellent condition.

@ehfd
Copy link
Member Author

ehfd commented May 8, 2024

@conda-forge/help-c-cpp Ready for review.

@ehfd ehfd marked this pull request as ready for review May 8, 2024 17:40
@ehfd ehfd mentioned this pull request May 26, 2024
10 tasks
@hmaarrfk hmaarrfk merged commit 942612f into conda-forge:main Jun 1, 2024
5 checks passed
@ehfd ehfd deleted the wmctrl-cli branch June 2, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants