-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ml4xcube package #26342
add ml4xcube package #26342
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python, ready for review! |
recipes/ml4xcube/meta.yaml
Outdated
- pip | ||
run: | ||
- python >=3.8 | ||
- conda-forge::xcube |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the ::
in a package name preceded by the the channel (?). I think this could just be xcube
. Could you clarify why the dependency is listed the way that it is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing my Python package!
I wanted to install xcube
specifically from the conda-forge channel because the latest versions of this package are only available there.
As mentioned in this GitHub issue, the syntax channel::package
can be used in an environment.yml
file to force the installation from a specific channel. I assumed this would work in the meta.yaml
as well, so I used this approach to ensure that the package is installed from conda-forge.
Since I am not shure if this is the right approach for meta.yaml
I simply added a package version to the definition.
Thanks again for your review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On conda-forge we only pull from the conda-forge channel for requirements, and for end-users it's probably better to specify the correct version rather than trying to force a particular channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @synapticarbors,
Thank you for merging my code. I have been trying to find the ml4xcube package in the available conda-forge packages, but it seems it is not yet available for download. Could you please let me know when it will be possible to download it?
As I am new to this procedure, I would appreciate your feedback in this regard.
Best,
Julia
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feedstock was created here https://github.com/conda-forge/ml4xcube-feedstock but it didn't actual build the packages for some reason. Let me look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @synapticarbors,
I hope you're doing well. I wanted to follow up on the status of the ml4xcube package. Is there any update on why the package build didn't succeed. How could I proceed from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See conda-forge/ml4xcube-feedstock#2 (comment) -- one way to proceed would be to remove the pip check
there which I can do
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).