Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding (grayskull generated and completed recipe) for the pypi-hosted casq package #26508

Merged
merged 2 commits into from
May 30, 2024

Conversation

soli
Copy link
Contributor

@soli soli commented May 30, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/casq) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/casq:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/casq) and found it was in an excellent condition.

@soli
Copy link
Contributor Author

soli commented May 30, 2024

@conda-forge-admin, please ping team

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@soli
Copy link
Contributor Author

soli commented May 30, 2024

@conda-forge/help-python I guess the PR is ready for review.

@ocefpaf ocefpaf merged commit 47167b6 into conda-forge:main May 30, 2024
5 checks passed
@soli
Copy link
Contributor Author

soli commented May 30, 2024

Thanks @ocefpaf !

@soli soli deleted the casq branch May 30, 2024 12:03
@soli
Copy link
Contributor Author

soli commented May 30, 2024

Hey @ocefpaf sorry to bother you but apparently the package failed to build on Azure (https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=945506&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=986b1512-c876-5f92-0d81-ba851554a0a3&l=675) and I'm not sure who to ask for help (no idea why "import casq" would fail to be honest). Can you point me in the right direction to try and debug this?

@ocefpaf
Copy link
Member

ocefpaf commented May 30, 2024

Odd that it passed here but failed in the feedstock. I'll investigate...

@soli
Copy link
Contributor Author

soli commented Jun 7, 2024

You're probably quite busy, but if I may be of any help, please keep me posted!

@ocefpaf is there something I can do?

@soli
Copy link
Contributor Author

soli commented Jun 28, 2024

@conda-forge/help-python Can anyone help me understand what I can do to fix this?

@ocefpaf
Copy link
Member

ocefpaf commented Jun 28, 2024

I tried to build it locally and the package is empty. I don't know how it passed in staged-recipes but not in the CIs. While there are a few build deps version that got upgraded, none that would explain that behavior. I'm at a loss here :-/

Maybe as in our element room chat to give a chance for more people to see this problem. Maybe someone knows what to do here.

@soli
Copy link
Contributor Author

soli commented Jun 28, 2024

Ok thanks I'll try that, but what do you mean "the package is empty"? Does this mean the conda recipe fails building the package from the source dist?

@bollwyvl
Copy link
Contributor

it's the hatch vs the new conda-smithy default .gitignore junk again:

# pyproejct.toml
[tool.hatch.build.targets.wheel]
ignore-vcs = true

You could either propose that change upstream, or hot append it to the end of pyproject.toml. I don't think there's an environment variable workaround or anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants