Add xfig #2651
Add xfig #2651
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
AppVeyor fails to even start due to missing curl (posted as issue #2652) |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/xfig:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Can you rebase this? Seems to be a lot of commits that aren't relevant in this pull request. |
|
@mariusvniekerk Fixed |
recipes/xfig/build.sh
Outdated
| # Point to the right pkgconfig | ||
| export PKG_CONFIG_LIBDIR="$PREFIX/lib/pkgconfig" | ||
| # Add the build-dir's lib dir to the linker flags | ||
| export LDFLAGS="-L$PREFIX/lib" |
There was a problem hiding this comment.
I think this to be `export LDFLAGS="${LDFLAGS} -L$PREFIX/lib" so you don't overwrite what's being set in the toolchain activate.sh
recipes/xfig/build.sh
Outdated
| # Add the build-dir's lib dir to the linker flags | ||
| export LDFLAGS="-L$PREFIX/lib" | ||
| # Add the build-dir's incude dir to the compiler flags | ||
| export CFLAGS="-I$PREFIX/include" |
There was a problem hiding this comment.
Same here. I think this to be `export CFLAGS="${CFLAGS} -I$PREFIX/include" so you don't overwrite what's being set in the toolchain activate.sh.
recipes/xfig/build.sh
Outdated
|
|
||
| make -j$CPU_COUNT | ||
|
|
||
| make install |
There was a problem hiding this comment.
Is there a make test that could be run also?
recipes/xfig/meta.yaml
Outdated
| build: | ||
| - toolchain | ||
| - libpng | ||
| - jpeg |
There was a problem hiding this comment.
Please pin jpeg and libpng as defined here for both build and runtime requirements. Those pinnings are jpeg 9* and libpng >=1.6.28,<1.7
- Don't overwrite `LDFLAGS` or `CFLAGS` - Use `make check` - Pin versions of `libpng` and `jpeg`
|
@ericdill Done. Thx for review! |
|
Appveyor is actually done and ✅ . Not sure why github still thinks its running. Guess the webhook got swallowed by something. This LGTM. Anything that I missed can be fixed in the feedstock. Thanks @epruesse |
No description provided.