Add recipe for conda-devenv #2657
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
AppVeyor is currently broken: conda-forge/conda-smithy#489 |
recipes/conda-devenv/meta.yaml
Outdated
|
|
||
| source: | ||
| git_rev: {{ version }} | ||
| git_url: https://github.com/ESSS/conda-devenv.git |
There was a problem hiding this comment.
Is there a tag or release on PyPI that we can use?
There was a problem hiding this comment.
There's a tag on the repository, but we don't pretend to release to PyPI since it is meant to be used with conda only (like conda-smithy itself for example).
There was a problem hiding this comment.
Tag on the repo is fine. We just prefer to download a tarball instead of cloning is all.
There was a problem hiding this comment.
Oh OK, will update it.
recipes/conda-devenv/meta.yaml
Outdated
|
|
||
| build: | ||
| number: 0 | ||
| script: python setup.py install --single-version-externally-managed --record record.txt |
There was a problem hiding this comment.
Please add...
entry_points:
- conda-devenv = conda_devenv.devenv:main
|
CI just passed. 👍 |
|
Oops @jakirkham did not see your comments. |
nicoddemus
force-pushed
the
conda-devenv
branch
from
a3575a1
to
f8aae30
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/conda-devenv:
|
nicoddemus
force-pushed
the
conda-devenv
branch
from
f8aae30
to
72f6703
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hmm it seems we have reached the rate limit for AppVeyor. |
|
There's a rate limit? |
nicoddemus
force-pushed
the
conda-devenv
branch
from
72f6703
to
53b47ac
Compare
|
Yes, there is a GitHub rate limit per user for requests to GitHub. Basically a security measure to avoid flooding GitHub with requests, but also some other reasons as well. AppVeyor makes all calls with one user, but I think other CIs attach them to the user doing the PR. Not sure why they can't change it though. 😕 ( appveyor/ci#1002 ) |
|
Well that rate limit ended really fast. We must have been down to the last couple minutes. Take the win I guess. 😄 |
recipes/conda-devenv/meta.yaml
Outdated
| version: {{ version }} | ||
|
|
||
| source: | ||
| fn: '{{ version }}.tar.gz' |
There was a problem hiding this comment.
Optional, but could structure your filename like this. Helps with caching (and finding things 😄) if one does a lot of builds locally.
recipes/conda-devenv/meta.yaml
Outdated
| {% set name = "conda-devenv" %} | ||
| {% set version = "0.9.1" %} | ||
| {% set hash = "fe8e9be7d4f2df03b9a269a4b4b36ca67477c9b1d5c2af1af440f63b787f2f05" %} | ||
| package: |
There was a problem hiding this comment.
Could we please have a newline between package and the Jinja?
recipes/conda-devenv/meta.yaml
Outdated
| number: 0 | ||
| script: python setup.py install --single-version-externally-managed --record record.txt | ||
| entry_points: | ||
| - conda-devenv = conda_devenv.devenv:main |
There was a problem hiding this comment.
nit: Would be nice if the indent size is uniform (e.g. only 2 spaces more here than entry_points).
nicoddemus
force-pushed
the
conda-devenv
branch
from
53b47ac
to
2206d64
Compare
|
Hmm I just noticed recently that the Travis builds are starting much quicker than before. Did Travis add more OSX hosts to its build farm perhaps? |
|
I don't think they have added any workers. The real cause, I believe, was fixing this issue. Basically we started noticing that simple steps were taking absurd amounts of time (particularly at high usage times). This likely caused this massive build in the queue as workers took longer to do the same thing than usual. Shortly after we pointed this out to them, that issue got opened and the problem resolved. They also did some follow-up maintenance. After they completed the maintenance, we start seeing a significant improvement (see a screenshot of the status below). In other words, we have likely been suffering from degraded service for months, which has caused the massive backlogs. Note the backlogs were in the ~1000s before now they are in the ~100s. So order of magnitude improvement. FWIW you can thank @gqmelo for helping discover this issue.
|
|
Nice @jakirkham, thanks for the detailed response! I will thank @gqmelo personally tomorrow then! 👍 |
|
Thanks @nicoddemus. |
cc @tadeu @gqmelo @edisongustavo