Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py2cfg #26658

Merged
merged 11 commits into from
Jun 16, 2024
Merged

Add py2cfg #26658

merged 11 commits into from
Jun 16, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jun 15, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/py2cfg, recipes/websocket-server) and found it was in an excellent condition.

@jan-janssen
Copy link
Member Author

@conda-forge/staged-recipes, ready for review

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@jan-janssen
Copy link
Member Author

@conda-forge/help-python

@jan-janssen
Copy link
Member Author

The windows tests fail, still I would prefer this package to remain noarch:

import: 'py2cfg'
No broken requirements found.
Traceback (most recent call last):
  File "C:\bld\py2cfg_1718453303736\_test_env\Scripts\py2cfg-script.py", line 5, in <module>
    from py2cfg._runner import main
  File "C:\bld\py2cfg_1718453303736\_test_env\lib\site-packages\py2cfg\_runner.py", line 10, in <module>
    import pty
  File "C:\bld\py2cfg_1718453303736\_test_env\lib\pty.py", line 12, in <module>
    import tty
  File "C:\bld\py2cfg_1718453303736\_test_env\lib\tty.py", line 5, in <module>
    from termios import *
ModuleNotFoundError: No module named 'termios'

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can stay noarch but it should not be installable on Windows

recipes/py2cfg/meta.yaml Show resolved Hide resolved
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@jan-janssen
Copy link
Member Author

@xhochy Thanks a lot, I updated the pull request accordingly

@xhochy xhochy merged commit 4906c8f into conda-forge:main Jun 16, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants