New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add recipe for libsndfile #2689
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/libsndfile/meta.yaml
Outdated
home: http://www.mega-nerd.com/libsndfile | ||
license: LGPL-2.1 | ||
license_family: LGPL | ||
license_file: '{{ environ["RECIPE_DIR"] }}/LICENSE' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please submit a PR to https://github.com/erikd/libsndfile/ including the LICENSE in that project and then add a comment to this recipe that links to that PR so we know when we can stop including the LICENSE here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand what you want me to put in the PR to libsndfile
repo.
Can you please be more specific?
FYI, all I did was copying https://github.com/erikd/libsndfile/blob/master/COPYING into LICENSE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, the license is already in the project. Great! Change the license_file line to: license_file: COPYING
and you don't need to bundle LICENSE with this recipe.
recipes/libsndfile/meta.yaml
Outdated
license: LGPL-2.1 | ||
license_family: LGPL | ||
license_file: '{{ environ["RECIPE_DIR"] }}/LICENSE' | ||
summary: "libsndfile - a C library for reading and writing files containing sampled sound (such as MS Windows WAV and the Apple/SGI AIFF format) through one standard library interface" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add
dev_url: https://github.com/erikd/libsndfile
recipes/libsndfile/meta.yaml
Outdated
@@ -0,0 +1,39 @@ | |||
{% set name = "libsndfile" %} | |||
{% set version = "1.0.27" %} | |||
{% set md5 = "fd1d97c6077f03b5d984d7956ffedb7a" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda-forge prefers sha256. In this case a391952f27f4a92ceb2b4c06493ac107896ed6c76be9a613a4731f076d30fac0
Oh come on github... there are no conflicts here 🤦♂️ Can you rebase this and the argtable PR onto master? |
No description provided.