Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add recipe for Yaafe #2709

Merged
merged 8 commits into from
Apr 4, 2017
Merged

Conversation

hbredin
Copy link
Contributor

@hbredin hbredin commented Mar 31, 2017

@ericdill this recipe depends on the other three (libsndfile, mpg123, and argtable2)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/yaafe) and found it was in an excellent condition.

@hbredin
Copy link
Contributor Author

hbredin commented Apr 4, 2017

@ericdill now that all three dependencies are available, how can I force CI to try again?

@ericdill
Copy link
Member

ericdill commented Apr 4, 2017

A rebase onto origin/master should do it. If that doesn't work, I can manually restart the CI builds for this PR

@hbredin
Copy link
Contributor Author

hbredin commented Apr 4, 2017

If you don't mind, that would be great.
Otherwise it will wait until next week when I can access a terminal.

@thomasfillon thomasfillon mentioned this pull request Apr 4, 2017
5 tasks
@ericdill
Copy link
Member

ericdill commented Apr 4, 2017

@hbredin Restarted all three services. 🤞

@thomasfillon
Copy link

thomasfillon commented Apr 4, 2017

From the details in CircleCI build log:

ERROR: cannot load yaafe component library "libyaafe-io.so" !
libFLAC.so.8: cannot open shared object file: No such file or directory
WARNING: cannot load yaafe-io component library !

I think the libsnd recipe lacks of run requirements.

In meta.yml:

requirements:
  build:
    - toolchain
    - libflac
    - libvorbis
    - libogg

You may need to add:

  run:
    - libflac
    - libvorbis
    - libogg

to these requirements.
I don't know if toolchain is also require for running.

you may also have a look at the recipe here: https://anaconda.org/trung/libsndfile/files

@hbredin
Copy link
Contributor Author

hbredin commented Apr 4, 2017

I am out of office. Can you do a pull request on libsndfile-feedstock?

@thomasfillon
Copy link

thomasfillon commented Apr 4, 2017

yes of course.

see conda-forge/libsndfile-feedstock#1

@hbredin
Copy link
Contributor Author

hbredin commented Apr 4, 2017

Looks like that solved the issue.

@ericdill
Copy link
Member

ericdill commented Apr 4, 2017

Nice catch @thomasfillon ! Thanks @hbredin and @thomasfillon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants