Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backoff 1.4.3 (PyPi) #2991

Merged
merged 7 commits into from
May 30, 2017
Merged

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented May 18, 2017

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/backoff) and found it was in an excellent condition.

@gatesn gatesn changed the title Add recipe for backoff 1.3.1 backoff 1.3.1 (PyPi) May 18, 2017
about:
home: https://github.com/litl/backoff
license: MIT
license_family: MIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the license_file as described here:

https://github.com/litl/backoff

and also possibly add the license file to the upstream MANIFEST.in so it's packaged with releases of backoff in the future (the recipe can be updated at that point to use the one that comes with the source).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the LICENSE to the manifest, and just released backoff 1.4.3 which now includes the license file in the sdist tarball.

extra:
recipe-maintainers:
- gatesn
- bgreen-litl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgreen-litl are you ok with being added as a co-maintainer of the backoff package on conda-forge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have spoken to @bgreen-litl offline and confirmed this is ok.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thank you.

@@ -0,0 +1,43 @@
{% set name = "backoff" %}
{% set version = "1.3.1" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest release is 1.4.2. Any reason to be packaging an older version?

@gatesn gatesn changed the title backoff 1.3.1 (PyPi) backoff 1.4.2 (PyPi) May 19, 2017
bgreen-litl added a commit to litl/backoff that referenced this pull request May 22, 2017
@bgreen-litl
Copy link

@gatesn if you set the version to backoff 1.4.3 now the LICENSE file should automatically be included. Do we know what the failing checks are about?

@gatesn gatesn changed the title backoff 1.4.2 (PyPi) backoff 1.4.3 (PyPi) May 29, 2017
@gatesn
Copy link
Contributor Author

gatesn commented May 29, 2017

@synapticarbors have bumped to 1.4.3, the version that includes the LICENSE file in the manifest.

@synapticarbors synapticarbors merged commit 47e3565 into conda-forge:master May 30, 2017
@gatesn gatesn deleted the ngates/backoff branch January 10, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants