-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backoff 1.4.3 (PyPi) #2991
backoff 1.4.3 (PyPi) #2991
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
about: | ||
home: https://github.com/litl/backoff | ||
license: MIT | ||
license_family: MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the license_file
as described here:
https://github.com/litl/backoff
and also possibly add the license file to the upstream MANIFEST.in
so it's packaged with releases of backoff
in the future (the recipe can be updated at that point to use the one that comes with the source).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the LICENSE to the manifest, and just released backoff 1.4.3 which now includes the license file in the sdist tarball.
extra: | ||
recipe-maintainers: | ||
- gatesn | ||
- bgreen-litl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgreen-litl are you ok with being added as a co-maintainer of the backoff
package on conda-forge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have spoken to @bgreen-litl offline and confirmed this is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Thank you.
recipes/backoff/meta.yaml
Outdated
@@ -0,0 +1,43 @@ | |||
{% set name = "backoff" %} | |||
{% set version = "1.3.1" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest release is 1.4.2
. Any reason to be packaging an older version?
@gatesn if you set the version to backoff 1.4.3 now the LICENSE file should automatically be included. Do we know what the failing checks are about? |
@synapticarbors have bumped to 1.4.3, the version that includes the LICENSE file in the manifest. |
No description provided.