Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libidn11 #3126

Merged
merged 3 commits into from
Jun 16, 2017
Merged

Add libidn11 #3126

merged 3 commits into from
Jun 16, 2017

Conversation

epruesse
Copy link
Member

@epruesse epruesse commented Jun 13, 2017

Libidn is a package for internationalized string handling based on the
Stringprep, Punycode, IDNA and TLD specifications.
  • It's in bioconda, but missing in conda.
  • Using libidn11 as package name to reflect so-version and avoid run-time binding issues at a later time.
  • Name also avoids override by weirdly versioned bioconda package (7.x).

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libidn) and found some lint.

Here's what I've got...

For recipes/libidn:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libidn) and found it was in an excellent condition.

@epruesse
Copy link
Member Author

@conda-forge/core Ready for review :)

@epruesse
Copy link
Member Author

Just noticed that AppVeyor didn't run. Will push dummy commit to try triggering it. If it doesn't work -- defer win support to feedstock?

@epruesse
Copy link
Member Author

Re win: waiting to see what AppVeyor does on first commit, only added Maintainer after that.

@scopatz
Copy link
Member

scopatz commented Jun 15, 2017

Hmm odd, appveyor still didn't run.

@epruesse
Copy link
Member Author

@scopatz It's that thing where it sometimes just doesn't. I need to push a patch anyway: AppVeyor finally ran on an earlier commit and I've got a mistake to fix.

@epruesse
Copy link
Member Author

@conda-forge/core All tests have passed. Can someone review?

@scopatz scopatz merged commit b8c6164 into conda-forge:master Jun 16, 2017
@scopatz
Copy link
Member

scopatz commented Jun 16, 2017

Thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants