added urwid recipe #316
added urwid recipe #316
Conversation
|
Hi! This is the friendly conda-forge-admin automated user. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| @@ -0,0 +1,2 @@ | |||
| @echo print('An example') > %SP_DIR%\example.py | |||
|
Also, how does one disable windows packages such as for this? |
|
Ah ok, now it makes sense. Happy to show you. |
| md5: 2e1a005cb31368fe21bfeba2d6ad5a5c | ||
|
|
||
| build: | ||
| number: 0 |
There was a problem hiding this comment.
Simply add the following after the build number in the build section.
skip: true # [win]
There was a problem hiding this comment.
Ahh Ok. I think I remember seeing this somewhere, but some better docs for this would be nice since I couldn't find it when I went looking for it :)
There was a problem hiding this comment.
Yes, we definitely need docs in general. This came up in discussion last week.
There was a problem hiding this comment.
As long as it is on the docket!
|
Ok @jakirkham I think I have made all of the requested changes! |
|
|
||
| build: | ||
| number: 0 | ||
| skip: true # [win] |
There was a problem hiding this comment.
We have also been folding one line scripts into the build section. If the package were using distutils only, it would look like this.
script: python setup.py install
However, as it uses setuptools, we add this.
script: python setup.py install --single-version-externally-managed --record record.txt
The additional arguments stop setuptools from handling some stuff for us that causes conda-build problems.
There was a problem hiding this comment.
It sort of seems like the example meta.yaml should contain all of these options and explanations as comments. That way, if you look at the example or just copy it over, it sort of serves as a walkthrough.
There was a problem hiding this comment.
Agreed. We probably should have a few examples to demonstrate common use cases. For instance, a simple pure Python program, a C/C++ program that is maybe UNIX only, and maybe a cross platform C/C++ program (Windows too). I think these are common cases that we answer very similar questions about.
Adding the linter bot has helped some by directing people to these issues. However, you are right we should simplify for people from the outset. It will save reviewer time and leave contributors, hopefully, more satisfied.
There was a problem hiding this comment.
Added this issue ( #318 ) to follow up on improving and adding more examples. Please feel free to share more thoughts on it.
|
One more fix and then we should be good. |
|
LGTM. Thanks @scopatz. |
|
Thanks! |
|
Of course. Thanks for your feedback on the process. Sometimes its difficult to see the forest from the trees. |
|
No problem! Thanks for all of your hard work. Happy to help in any way I can! |
Didn't see it yet...