Add recipe for Spyder #477

ccordoba12 · 2016-04-28T23:09:30Z

@msarahan, here it is the PR for Spyder you asked for :-)

conda-forge-linter · 2016-04-28T23:09:34Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/spyder) and found some lint.

Here's what I've got...

For recipes/spyder:

The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'app', 'about'].
The recipe could do with some maintainers listed in the "extra/recipe-maintainers" section.
Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

ocefpaf · 2016-04-28T23:55:46Z

recipes/spyder/meta.yaml

+    environment thanks to the support of IPython and popular Python libraries
+    such as NumPy, SciPy, or matplotlib.
+  doc_url: http://pythonhosted.org/spyder/
+  dev_url: https://github.com/spyder-ide/spyder


If that is the same as home maybe we don't really need it.

@ccordoba12 there is a mistake here

home should be: http://spyder-ide.org

The home web page is under construction so it is pointing to the github repo in the meantime

I changed the home field to reflect this :-)

jakirkham · 2016-04-28T23:59:34Z

Is the logo not in the repo? If it is, maybe we should use it from there.

jakirkham · 2016-04-29T00:00:56Z

recipes/spyder/meta.yaml

+
+source:
+  fn:  spyder-2.3.9.zip
+  url: https://pypi.python.org/packages/fb/37/09b789dbe321894afe1657f11f0026a5ea79987f1c30176b92ee648b3faa/spyder-2.3.9.zip


Switch to https://pypi.io/packages/source/s/spyder/spyder-2.3.9.zip.

jakirkham · 2016-04-29T00:04:55Z

With all the about stuff. I'm ok with whatever you want to do really, @ccordoba12. I'm not going to argue over it. Generally, we try to keep this stuff lean, but if you think it adds value that's fine by me.

conda-forge-linter · 2016-04-29T00:18:37Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/spyder) and found it was in an excellent condition.

jakirkham · 2016-04-29T00:19:44Z

recipes/spyder/meta.yaml

+
+extra:
+  recipe-maintainers:
+    ccordoba12


So, this needs to be a list.

ccordoba12 · 2016-04-29T00:59:22Z

This is failing because:

CircleCI is not using the latest conda-build (but 1.18.2) and so description is not a valid field in that version. Even after commenting that, I found that Spyder can't be tested because nor HOME or USER are defined in the Docker image. Can't that be changed?
Travis fails because of an error in conda-build 1.20.1 and Python 2.7. I'll see if I can submit a PR to fix it :-)

jakirkham · 2016-04-29T01:06:14Z

Travis fails because of an error in conda-build 1.20.1 and Python 2.7. I'll see if I can submit a PR to fix it :-)

This one should already be fixed by this PR ( conda/conda-build#892 ), but haven't had time to test it. Also, is not released.

jakirkham · 2016-04-29T01:07:59Z

CircleCI is not using the latest conda-build (but 1.18.2) and so description is not a valid field in that version. Even after commenting that, I found that Spyder can't be tested because nor HOME or USER are defined in the Docker image. Can't that be changed?

Should be updated I think. Unless it is getting pinned somewhere else.

jakirkham · 2016-04-29T01:09:01Z

I think you are on a really old commit, @ccordoba12. If you rebase or merge with current master, I expect all of this will go away.

jakirkham · 2016-04-29T01:14:11Z

Yeah, actually, I checked. That is the cause. Just merge with conda-forge/master. We have either fixed or worked around all of these problems.

This reverts commit 2083003.

jakirkham · 2016-04-29T02:07:41Z

Added this PR ( ccordoba12#1 ) to merge your branch with current master. That should straighten out these remaining issues.

Spyder (merge `master`)

jakirkham · 2016-04-29T16:02:12Z

Looks like there is some encoding issue in the docker build.

+ spyder -h
Traceback (most recent call last):
  File "/opt/conda/envs/_test/bin/spyder", line 2, in <module>
    from spyderlib import start_app
  File "/opt/conda/envs/_test/lib/python2.7/site-packages/spyderlib/start_app.py", line 12, in <module>
    from spyderlib.baseconfig import get_conf_path, running_in_mac_app
  File "/opt/conda/envs/_test/lib/python2.7/site-packages/spyderlib/baseconfig.py", line 188, in <module>
    from spyderlib.otherplugins import PLUGIN_PATH
  File "/opt/conda/envs/_test/lib/python2.7/site-packages/spyderlib/otherplugins.py", line 17, in <module>
    from spyderlib.utils import programs
  File "/opt/conda/envs/_test/lib/python2.7/site-packages/spyderlib/utils/programs.py", line 29, in <module>
    username = encoding.to_unicode_from_fs(os.environ.get('USER'))
  File "/opt/conda/envs/_test/lib/python2.7/site-packages/spyderlib/utils/encoding.py", line 62, in to_unicode_from_fs
    string = to_text_string(string.toUtf8(), 'utf-8')
AttributeError: 'NoneType' object has no attribute 'toUtf8'

msarahan · 2016-04-29T16:09:32Z

No, that is because the USER env var is not set.

jakirkham · 2016-04-29T16:14:14Z

Ah, right. Hmm...should that case be handled by Spyder?

I guess we can just set a user in our docker image. At a bare minimum we can set that to root for now.

We probably should be adding a non-root user for security reasons. Though this image is not necessarily intended for any use beyond building on CIs or local debugging.

jakirkham · 2016-05-01T00:36:59Z

Sorry guys. I thought I had pinned conda-build correctly to avoid the Mac issue here, but I did not. Correcting it in this PR ( #488 ). Will merge as soon as it passes and restart CI here.

jakirkham · 2016-05-01T00:40:32Z

That PR is merged and CI has been restarted.

jakirkham · 2016-05-01T00:44:52Z

That fixed the Travis CI failure.

jakirkham · 2016-05-01T00:49:01Z

recipes/spyder/meta.yaml

+
+test:
+  commands:
+    - USER=test spyder -h  # [unix]


Kind of hacky, but I understand why we need this here and we may need it for a bit. Really we should change the docker image to be a little more realistic on this point. I've added an issue ( conda-forge/docker-images#6 ) for changing the docker image.

I know that this a bit hacky, but useful for the moment :-)

It's fine. We should be doing a better job so that you don't have to do this. Just felt like I should add a note to explain to myself and others why we need to change the docker image to fix this.

jakirkham · 2016-05-01T01:56:56Z

CI is passing now. However, there a few issues mentioned above that I would like us to take care of before merging.

ccordoba12 · 2016-05-01T03:13:18Z

@jakirkham, I think this is ready :-)

Is the logo not in the repo? If it is, maybe we should use it from there.

The logo.png file is necessary for Anaconda Navigator.

I also left all new fields in the about section for Navigator.

jakirkham · 2016-05-01T04:05:26Z

Is the logo not in the repo? If it is, maybe we should use it from there.

The logo.png file is necessary for Anaconda Navigator.

I understand. I was just hoping that we could grab it from the zip on PyPI instead of having it bundled with the recipe. Would that be possible?

ccordoba12 · 2016-05-01T04:49:18Z

I was just hoping that we could grab it from the zip on PyPI instead of having it bundled with the recipe. Would that be possible?

I wouldn't like to explore this here but in the feedstock. Besides, it's a very small file :-)

ocefpaf · 2016-05-03T08:49:22Z

@ccordoba12 this LGTM. I am merging and any renaming issue can be addressed in the feedstock.

Awesome contribution! I will be using it soon to teach my tutorial at SciPyLA 2016 😉

Add recipe for Spyder

ff4921b

ocefpaf reviewed Apr 28, 2016
View reviewed changes

jakirkham reviewed Apr 29, 2016
View reviewed changes

Address several reviews

9248787

jakirkham reviewed Apr 29, 2016
View reviewed changes

recipes/spyder/meta.yaml

extra:

recipe-maintainers:

ccordoba12

Copy link

Member

jakirkham Apr 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this needs to be a list.

ccordoba12 added 2 commits April 28, 2016 19:28

Fix some errors

3320ec6

Comment description because CircleCI is failing with it

2083003

jakirkham added 2 commits April 28, 2016 22:05

Revert "Comment description because CircleCI is failing with it"

8d81133

This reverts commit 2083003.

Merge branch 'master' into spyder

8ea03a9

jakirkham mentioned this pull request Apr 29, 2016

Spyder (merge master) ccordoba12/staged-recipes#1

Merged

Merge pull request #1 from jakirkham/spyder

3d1a667

Spyder (merge `master`)

ccordoba12 added 3 commits April 29, 2016 11:03

Pin Jedi

479c5c0

Restore about fields and add goanpeca as maintainer

65bfa48

Last fixes

450fa3c

ccordoba12 added 2 commits April 29, 2016 14:52

Try to fix error in CircleCI

1542d4d

Fix tests on Windows

0d48e9d

jakirkham mentioned this pull request May 1, 2016

Make sure that USER is defined conda-forge/docker-images#6

Closed

jakirkham reviewed May 1, 2016
View reviewed changes

Last fixes

9e2e5b8

melund mentioned this pull request May 1, 2016

Updated recipe conda-forge/xonsh-feedstock#12

Merged

ocefpaf merged commit 50c6d1b into conda-forge:master May 3, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add recipe for Spyder #477

Add recipe for Spyder #477

ccordoba12 commented Apr 28, 2016

conda-forge-linter commented Apr 28, 2016

ocefpaf Apr 28, 2016

goanpeca Apr 29, 2016 •

edited

ccordoba12 May 1, 2016 •

edited

jakirkham commented Apr 28, 2016 •

edited

jakirkham Apr 29, 2016

jakirkham commented Apr 29, 2016

conda-forge-linter commented Apr 29, 2016

jakirkham Apr 29, 2016

ccordoba12 commented Apr 29, 2016

jakirkham commented Apr 29, 2016 •

edited

jakirkham commented Apr 29, 2016

jakirkham commented Apr 29, 2016

jakirkham commented Apr 29, 2016

jakirkham commented Apr 29, 2016

jakirkham commented Apr 29, 2016

msarahan commented Apr 29, 2016

jakirkham commented Apr 29, 2016

jakirkham commented May 1, 2016

jakirkham commented May 1, 2016

jakirkham commented May 1, 2016

jakirkham May 1, 2016 •

edited

ccordoba12 May 1, 2016

jakirkham May 1, 2016

jakirkham commented May 1, 2016

ccordoba12 commented May 1, 2016 •

edited

jakirkham commented May 1, 2016

ccordoba12 commented May 1, 2016

ocefpaf commented May 3, 2016

Add recipe for Spyder #477

Add recipe for Spyder #477

Conversation

ccordoba12 commented Apr 28, 2016

conda-forge-linter commented Apr 28, 2016

ocefpaf Apr 28, 2016

Choose a reason for hiding this comment

goanpeca Apr 29, 2016 • edited

Choose a reason for hiding this comment

ccordoba12 May 1, 2016 • edited

Choose a reason for hiding this comment

jakirkham commented Apr 28, 2016 • edited

jakirkham Apr 29, 2016

Choose a reason for hiding this comment

jakirkham commented Apr 29, 2016

conda-forge-linter commented Apr 29, 2016

jakirkham Apr 29, 2016

Choose a reason for hiding this comment

ccordoba12 commented Apr 29, 2016

jakirkham commented Apr 29, 2016 • edited

jakirkham commented Apr 29, 2016

jakirkham commented Apr 29, 2016

jakirkham commented Apr 29, 2016

jakirkham commented Apr 29, 2016

jakirkham commented Apr 29, 2016

msarahan commented Apr 29, 2016

jakirkham commented Apr 29, 2016

jakirkham commented May 1, 2016

jakirkham commented May 1, 2016

jakirkham commented May 1, 2016

jakirkham May 1, 2016 • edited

Choose a reason for hiding this comment

ccordoba12 May 1, 2016

Choose a reason for hiding this comment

jakirkham May 1, 2016

Choose a reason for hiding this comment

jakirkham commented May 1, 2016

ccordoba12 commented May 1, 2016 • edited

jakirkham commented May 1, 2016

ccordoba12 commented May 1, 2016

ocefpaf commented May 3, 2016

goanpeca Apr 29, 2016 •

edited

ccordoba12 May 1, 2016 •

edited

jakirkham commented Apr 28, 2016 •

edited

jakirkham commented Apr 29, 2016 •

edited

jakirkham May 1, 2016 •

edited

ccordoba12 commented May 1, 2016 •

edited