Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add astral 1.6.1 recipe #6623

Merged
merged 3 commits into from
Sep 7, 2018
Merged

add astral 1.6.1 recipe #6623

merged 3 commits into from
Sep 7, 2018

Conversation

hajapy
Copy link
Contributor

@hajapy hajapy commented Sep 5, 2018

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/astral) and found it was in an excellent condition.

Copy link
Member

@synapticarbors synapticarbors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, but otherwise looks good to me. I'm happy to merge once it's noarch and the conda-build issue is fixed.

sha256: ab0c08f2467d35fcaeb7bad15274743d3ac1ad18b5391f64a0058a9cd192d37d

build:
#noarch: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably be a noarch package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! I commented it out to test if it was responsible for the failure, which we now know is due an upstream conda-build issue. I'll uncomment this and rebuild after that is fixed (and address any real build issues that may come up!)

@hajapy
Copy link
Contributor Author

hajapy commented Sep 7, 2018

Thanks @marcelotrevisani for the commit ;)
@synapticarbors PR is ready now as noarch

@marcelotrevisani
Copy link
Member

LGTM
I'm going to merge this. Thanks to put this in conda-forge

@marcelotrevisani marcelotrevisani merged commit 0f7a2a3 into conda-forge:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants