New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spooles #6661
add spooles #6661
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/spooles:
|
it seems to not have a license. What should I do? |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/spooles:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/staged-recipes please review and create feedstock. Windows is not yet enabled. I guess some more work is needed for windows... |
recipes/spooles/meta.yaml
Outdated
home: http://www.netlib.org/linalg/spooles/spooles.2.2.html | ||
summary: 'Simple, fast, extensible JSON encoder/decoder for Python' | ||
license: LGPL # the project has no restrictions. aur lists gpl as license | ||
license_family: LGPL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to have the licensr_file entry here since this is lgpl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it is public domain though, from http://www.netlib.org/linalg/spooles/spooles.2.2.html:
This release is entirely within the public domain; there are no licensing restrictions,
and there is no warranty of any sort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The aur-package lists gpl: https://aur.archlinux.org/packages/spooles/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is weird, because arch also says it is public domain: https://aur.archlinux.org/cgit/aur.git/tree/license.txt?h=spooles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that the Arch
packager made a mistake :-/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So how to proceed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So how to proceed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go with what is in the official website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, remove the LGPL references
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/spooles:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
this way? |
recipes/spooles/meta.yaml
Outdated
@@ -28,8 +28,8 @@ test: | |||
about: | |||
home: http://www.netlib.org/linalg/spooles/spooles.2.2.html | |||
summary: 'Simple, fast, extensible JSON encoder/decoder for Python' | |||
license: LGPL # the project has no restrictions. aur lists gpl as license | |||
license_family: LGPL | |||
license: - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please write: Public Domain
here.
Thanks guys. I think this is now ready for feedstock. Or is there any volunteer who wants to help with the windows build? |
Thanks @looooo! |
No description provided.