Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spooles #6661

Merged
merged 8 commits into from Oct 8, 2018
Merged

add spooles #6661

merged 8 commits into from Oct 8, 2018

Conversation

looooo
Copy link
Contributor

@looooo looooo commented Sep 12, 2018

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/spooles) and found some lint.

Here's what I've got...

For recipes/spooles:

  • The license item is expected in the about section.
  • The build section contained an unexpected subsection name. skipt is not a valid subsection name.

@looooo
Copy link
Contributor Author

looooo commented Sep 12, 2018

it seems to not have a license. What should I do?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/spooles) and found some lint.

Here's what I've got...

For recipes/spooles:

  • The license item is expected in the about section.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/spooles) and found it was in an excellent condition.

@looooo
Copy link
Contributor Author

looooo commented Oct 2, 2018

@conda-forge/staged-recipes please review and create feedstock. Windows is not yet enabled. I guess some more work is needed for windows...

home: http://www.netlib.org/linalg/spooles/spooles.2.2.html
summary: 'Simple, fast, extensible JSON encoder/decoder for Python'
license: LGPL # the project has no restrictions. aur lists gpl as license
license_family: LGPL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to have the licensr_file entry here since this is lgpl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is public domain though, from http://www.netlib.org/linalg/spooles/spooles.2.2.html:

This release is entirely within the public domain; there are no licensing restrictions,
and there is no warranty of any sort.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aur-package lists gpl: https://aur.archlinux.org/packages/spooles/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is weird, because arch also says it is public domain: https://aur.archlinux.org/cgit/aur.git/tree/license.txt?h=spooles

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that the Arch packager made a mistake :-/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how to proceed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how to proceed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go with what is in the official website.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, remove the LGPL references

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/spooles) and found some lint.

Here's what I've got...

For recipes/spooles:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/spooles) and found it was in an excellent condition.

@looooo
Copy link
Contributor Author

looooo commented Oct 6, 2018

this way?

@@ -28,8 +28,8 @@ test:
about:
home: http://www.netlib.org/linalg/spooles/spooles.2.2.html
summary: 'Simple, fast, extensible JSON encoder/decoder for Python'
license: LGPL # the project has no restrictions. aur lists gpl as license
license_family: LGPL
license: -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please write: Public Domain here.

@looooo
Copy link
Contributor Author

looooo commented Oct 7, 2018

Thanks guys. I think this is now ready for feedstock. Or is there any volunteer who wants to help with the windows build?

@scopatz scopatz merged commit f4ed246 into conda-forge:master Oct 8, 2018
@scopatz
Copy link
Member

scopatz commented Oct 8, 2018

Thanks @looooo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants