Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pysheds #7421

Merged
merged 13 commits into from
Jan 13, 2019
Merged

Add pysheds #7421

merged 13 commits into from
Jan 13, 2019

Conversation

mdbartos
Copy link
Contributor

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pysheds) and found it was in an excellent condition.

@mdbartos
Copy link
Contributor Author

mdbartos commented Jan 7, 2019

Ping @conda-forge/staged-recipes

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I noticed a few things.

- python >= 3
- pip
run:
- python >= 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the python versions specs should be python >=3

recipes/pysheds/meta.yaml Show resolved Hide resolved
recipes/pysheds/LICENSE Show resolved Hide resolved
@mdbartos
Copy link
Contributor Author

Hi @beckermr, thanks for the review. It looks like the appveyor build is failing because the build script is appending py>=3 to the workspace name, and > is an invalid character in Windows file paths. Do you know any workarounds for this issue?

Thanks,
MDB

@beckermr
Copy link
Member

beckermr commented Jan 12, 2019

Try adding ‘skip: True # [py2k]’ in the build section and remove the python version selector.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pysheds) and found some lint.

Here's what I've got...

For recipes/pysheds:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [13]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pysheds) and found it was in an excellent condition.

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@beckermr beckermr merged commit 273d39d into conda-forge:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants