Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP google-differential-privacy #9975

Closed
wants to merge 9 commits into from
Closed

Conversation

mwilson8
Copy link
Contributor

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/google-differential-privacy) and found it was in an excellent condition.

@mwilson8
Copy link
Contributor Author

@jakirkham

@jakirkham
Copy link
Member

cc @conda-forge/staged-recipes

- {{ compiler('cxx') }}
- openjdk
- pip
- python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are pip and python in build?

- openjdk
- pip
- python
- postgresql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is postgresql in build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just based off of the languages listed on the homepage, I was assuming they'd be needed

@mwilson8
Copy link
Contributor Author

@jakirkham removing those lines causes a error about not finding postgres

@jakirkham
Copy link
Member

Unfortunately a bit saturated ATM.

Let's see if anyone else has ideas. @conda-forge/staged-recipes?

@mwilson8
Copy link
Contributor Author

mwilson8 commented Nov 4, 2019

re-ping @conda-forge/staged-recipes any help is greatly appreciated

@mwilson8
Copy link
Contributor Author

mwilson8 commented Nov 5, 2019

@ocefpaf @jjhelmus the tensorflow-hub-feedstock is the only other feedstock I found that uses bazel to build; I'm having a good bit of trouble with this PR. Would you be able to provide any assistance?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/google-differential-privacy, recipes/rules_foreign_cc) and found some lint.

Here's what I've got...

For recipes/rules_foreign_cc:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/google-differential-privacy, recipes/rules_foreign_cc) and found it was in an excellent condition.

@mariusvniekerk
Copy link
Member

You probably need to set CMAKE_CXX_FLAGS and some others

@mwilson8
Copy link
Contributor Author

mwilson8 commented Nov 6, 2019

as of the most recent commit, I'm receiving an error about not being able to find the "readline" package, although I have it included in the meta file

@mwilson8
Copy link
Contributor Author

mwilson8 commented Nov 7, 2019

From what I can tell, this error is caused from postgres.. presumably while it's trying to build from source..? @mariusvniekerk as a maintainer on postgres or @jakirkham as a maintainer on readline, any idea why I'm getting this error?

checking for library containing readline... no
configure: error: readline library not found
If you have readline already installed, see config.log for details on the
failure.  It is possible the compiler isn't looking in the proper directory.
Use --without-readline to disable readline support.

@mwilson8
Copy link
Contributor Author

mwilson8 commented Nov 7, 2019

It seems that the conda-forge version of bazel(0.20.0) is way behind the current version(1.1.0).. this could be the root cause, but unsure

@stale
Copy link

stale bot commented Apr 5, 2020

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Apr 5, 2020
@stale
Copy link

stale bot commented May 5, 2020

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

None yet

4 participants