Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stempeg #9998

Merged
merged 7 commits into from
Oct 28, 2019
Merged

Stempeg #9998

merged 7 commits into from
Oct 28, 2019

Conversation

Faylixe
Copy link
Contributor

@Faylixe Faylixe commented Oct 28, 2019

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/stempeg) and found it was in an excellent condition.

@Faylixe Faylixe mentioned this pull request Oct 28, 2019
7 tasks
@marcelotrevisani
Copy link
Member

You will have to skip windows for this recipe, there is no libsndfile for windows

@marcelotrevisani
Copy link
Member

I will push one modification

@Faylixe
Copy link
Contributor Author

Faylixe commented Oct 28, 2019

You will have to skip windows for this recipe, there is no libsndfile for windows

Because it is not available on Conda ? The dependency to pysoundfile is described as working under Windows platform.

@marcelotrevisani
Copy link
Member

You will have to skip windows for this recipe, there is no libsndfile for windows

Because it is not available on Conda ? The dependency to pysoundfile is described as working under Windows platform.

Yeah, but pysoundfile rely on libsndfile
That recipe is wrong, actually... I opened a PR to change it
However, if you want to give a try, you can try to build libsndfile for windows and it will solve all those things.

@Faylixe
Copy link
Contributor Author

Faylixe commented Oct 28, 2019

You will have to skip windows for this recipe, there is no libsndfile for windows

Because it is not available on Conda ? The dependency to pysoundfile is described as working under Windows platform.

Yeah, but pysoundfile rely on libsndfile
That recipe is wrong, actually... I opened a PR to change it
However, if you want to give a try, you can try to build libsndfile for windows and it will solve all those things.

I actually think I will for a next release of this package, a first iteration with only UNIX platform support is OK for us by now. I will update parent package musdb as well to restrict usage and exclude windows platform then.

Thanks you for the whole review :)

@Faylixe
Copy link
Contributor Author

Faylixe commented Oct 28, 2019

(is it possible to merge now then so I can move forward on musdb package ?)

@marcelotrevisani marcelotrevisani merged commit c622e74 into conda-forge:master Oct 28, 2019
@Faylixe Faylixe deleted the stempeg branch October 28, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants