Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SymEngine 0.12.0 #47

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Update to SymEngine 0.12.0 #47

merged 2 commits into from
Jun 12, 2024

Conversation

anutosh491
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
  • You are setting MACOSX_SDK_VERSION below c_stdlib_version, in conda_build_config.yaml which is not possible! Please ensure MACOSX_SDK_VERSION is at least c_stdlib_version (you can leave it out if it is equal).
    If you are not setting c_stdlib_version yourself, this means you are requesting a version below the current global baseline in conda-forge. In this case, you also need to override c_stdlib_version and MACOSX_DEPLOYMENT_TARGET locally.

@anutosh491
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@anutosh491
Copy link
Contributor Author

anutosh491 commented May 24, 2024

cc @certik @isuruf might need some help from y'all addressing this.
So

  1. In the first commit I just changed the version and sha256 hash
  2. Followed by the re-rendering step
  3. Followed by addressing the suggestions by the linter.

@isuruf
Copy link
Member

isuruf commented May 24, 2024

@conda-forge-admin, rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • You are setting c_stdlib_version below the current global baseline in conda-forge. If this is your intention, you also need to override MACOSX_DEPLOYMENT_TARGET (with the same value) locally.

@anutosh491
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/symengine-feedstock/actions/runs/9223097418.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@anutosh491
Copy link
Contributor Author

@conda-forge-admin, please rerender

@anutosh491
Copy link
Contributor Author

The build fails with the log


    sys.exit(execute())
  File "/opt/conda/lib/python3.10/site-packages/conda_build/cli/main_build.py", line 590, in execute
    api.build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/api.py", line 250, in build
    return build_tree(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 3638, in build_tree
    packages_from_this = build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 2419, in build
    try_download(m, no_download_source=False, raise_error=True)
  File "/opt/conda/lib/python3.10/site-packages/conda_build/render.py", line 762, in try_download
    source.provide(metadata)
  File "/opt/conda/lib/python3.10/site-packages/conda_build/source.py", line 1035, in provide
    unpack(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/source.py", line 169, in unpack
    src_path, unhashed_fn = download_to_cache(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/source.py", line 116, in download_to_cache
    raise RuntimeError(f"Could not download {url}")
RuntimeError: Could not download https://github.com/symengine/symengine/releases/download/v0.12.0/symengine-0.12.0.tar.gz

@certik
Copy link
Contributor

certik commented May 25, 2024

@isuruf I just tagged the SymEngine release. Do we need to manually upload a tarball also?

@isuruf
Copy link
Member

isuruf commented May 25, 2024

Yes, I download the .tar.gz that github provides and reupload as an artifact. This is because the .tar.gz assets might change (when git protocol changes), but artifacts don't.

@certik
Copy link
Contributor

certik commented May 25, 2024

I see. If one of you could do it, that would be awesome. I'll be able to do it on Monday the latest.

@anutosh491
Copy link
Contributor Author

Hey @isuruf would you be able to look into the above comments. Not sure I can do those things as I lack member access to symengine.

@certik
Copy link
Contributor

certik commented May 27, 2024

I downloaded the tarball and uploaded it explicitly as an asset: https://github.com/symengine/symengine/releases/tag/v0.12.0.

@anutosh491 go ahead and try to get this PR working. I tried to restart the jobs, but it didn't do it. You probably have to push into this PR to get the CI running again.

@anutosh491
Copy link
Contributor Author

@conda-forge-admin, please rerender

@anutosh491
Copy link
Contributor Author

Hmm, not sure why the symengine-feedstock (win win_64_) would fail here returning an exception while testing test_cwrapper. All the windows 64 based test in the symengine CI pass perfectly on symengine's master !

@certik
Copy link
Contributor

certik commented May 28, 2024

Well, this is a bug in SymEngine that was only discovered now.

@isuruf we have two options:

  • we uncomment running the test here and publish the conda packages; will fix this in symengine and make a new relesae
  • we try to fix this in symengine, figure out a patch, and patch this release here

Which one would you prefer?

@isuruf
Copy link
Member

isuruf commented May 29, 2024

I'd prefer the second option. I'll try to reproduce this locally.

@anutosh491
Copy link
Contributor Author

Hey @isuruf were you able to repoduce the issue here ? Would be great if you could help us fix this. I'm presenting my work on symbolics with LPython at university in a weeks time and we would want to use symengine 0.12.0 there. So would be really helpful if you help us with this.

@anutosh491
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

github-actions bot commented Jun 1, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/symengine-feedstock/actions/runs/9327677200.

@certik
Copy link
Contributor

certik commented Jun 1, 2024

Let's get all tests passing, by disabling tests if needed, so that at least all conda packages build. We'll then decide how to go forward. We can also just disable the Windows build (since it doesn't build) and publish the linux/mac packages. That might be the preferable solution. But I think disabling the ctest is fine too.

@anutosh491
Copy link
Contributor Author

Yes the test_cwrapper fails on win not sure why (everything looked good on symengine's master) and even after sending the patch for commenting that out the windows build fails. As you said we could disable the windows build for now, publish the mac/linux packages and look into the error later

@anutosh491
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • In conda-forge.yml: $ = {'build_platform': {'linux_aarch64': 'linux_64', 'linux_ppc64le': 'linux_64', 'osx_arm64': 'osx_64'}, 'conda_forge_output_validation': True, 'github': {'branch_name': 'main', 'tooling_branch_name': 'main'}, 'provider': {'linux_aarch64': 'default', 'linux_ppc64le': 'default'}, 'conda_build': {'pkg_format': '2', 'error_overlinking': True}, 'test': 'native_and_emulated', 'skip_platforms': ['win']}.

    Additional properties are not allowed ('skip_platforms' was unexpected)

    Schema

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@anutosh491
Copy link
Contributor Author

@conda-forge-admin, please rerender

@anutosh491
Copy link
Contributor Author

@conda-forge-admin, rerender

@certik
Copy link
Contributor

certik commented Jun 12, 2024

@isuruf, we have a path forward by disabling the Windows build for now. Are you ok with going forward like this, and once we figure out what the problem is, we fix it and re-enable Windows?

@isuruf
Copy link
Member

isuruf commented Jun 12, 2024

Sure, that's fine for now

@certik certik merged commit 63a9907 into conda-forge:main Jun 12, 2024
7 checks passed
@certik
Copy link
Contributor

certik commented Jun 12, 2024

Ok, I merged this. @anutosh491 is responsible to get the Windows build working again. I can help.

@anutosh491
Copy link
Contributor Author

Yeah, let me raise an issue just to make a note of enabling the windows build again !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants