-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SymEngine 0.12.0 #47
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/symengine-feedstock/actions/runs/9223097418. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
The build fails with the log
|
@isuruf I just tagged the SymEngine release. Do we need to manually upload a tarball also? |
Yes, I download the .tar.gz that github provides and reupload as an artifact. This is because the .tar.gz assets might change (when git protocol changes), but artifacts don't. |
I see. If one of you could do it, that would be awesome. I'll be able to do it on Monday the latest. |
Hey @isuruf would you be able to look into the above comments. Not sure I can do those things as I lack member access to symengine. |
I downloaded the tarball and uploaded it explicitly as an asset: https://github.com/symengine/symengine/releases/tag/v0.12.0. @anutosh491 go ahead and try to get this PR working. I tried to restart the jobs, but it didn't do it. You probably have to push into this PR to get the CI running again. |
@conda-forge-admin, please rerender |
Hmm, not sure why the |
Well, this is a bug in SymEngine that was only discovered now. @isuruf we have two options:
Which one would you prefer? |
I'd prefer the second option. I'll try to reproduce this locally. |
Hey @isuruf were you able to repoduce the issue here ? Would be great if you could help us fix this. I'm presenting my work on symbolics with LPython at university in a weeks time and we would want to use symengine 0.12.0 there. So would be really helpful if you help us with this. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/symengine-feedstock/actions/runs/9327677200. |
Let's get all tests passing, by disabling tests if needed, so that at least all conda packages build. We'll then decide how to go forward. We can also just disable the Windows build (since it doesn't build) and publish the linux/mac packages. That might be the preferable solution. But I think disabling the ctest is fine too. |
Yes the test_cwrapper fails on win not sure why (everything looked good on symengine's master) and even after sending the patch for commenting that out the windows build fails. As you said we could disable the windows build for now, publish the mac/linux packages and look into the error later |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
@conda-forge-admin, rerender |
…nda-forge-pinning 2024.06.12.05.49.44
@isuruf, we have a path forward by disabling the Windows build for now. Are you ok with going forward like this, and once we figure out what the problem is, we fix it and re-enable Windows? |
Sure, that's fine for now |
Ok, I merged this. @anutosh491 is responsible to get the Windows build working again. I can help. |
Yeah, let me raise an issue just to make a note of enabling the windows build again ! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)