Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.15.0 for libgrpc159_libprotobuf4244 #361

Merged
merged 5 commits into from
Dec 22, 2023

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Dec 18, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

Thanks for tackling this! You might want to pull in #359 directly

@xhochy
Copy link
Member Author

xhochy commented Dec 20, 2023

@conda-forge/tensorflow All builds passed on linux-64 and one on osx-64. I will start the remaining osx-* builds this afternoon.

@h-vetinari
Copy link
Member

Amazing news! 🥳

@xhochy
Copy link
Member Author

xhochy commented Dec 21, 2023

@h-vetinari @hmaarrfk Builds are on the uwe.korn-tf-gpu and uwe.korn-tf-experimental channels again.

Logs:

@h-vetinari
Copy link
Member

This is the first time I'm trying to do a CFEP-03 copy... I looked at the build logs and noted a few minor things, that have to be pre-existing (given the changes here):

WARNING: Exact overlap between include/tensorflow/core/platform/ctstring.h in packages libtensorflow_cc and libtensorflow
WARNING: Exact overlap between include/tensorflow/core/platform/ctstring_internal.h in packages libtensorflow_cc and libtensorflow
WARNING: Exact overlap between include/tsl/c/tsl_status.h in packages libtensorflow_cc and libtensorflow
WARNING: Exact overlap between include/tsl/platform/ctstring.h in packages libtensorflow_cc and libtensorflow
WARNING: Exact overlap between include/tsl/platform/ctstring_internal.h in packages libtensorflow_cc and libtensorflow
WARNING: Exact overlap between lib/libtensorflow_framework.2.15.0.dylib in packages libtensorflow_cc and libtensorflow
WARNING: Exact overlap between lib/libtensorflow_framework.2.dylib in packages libtensorflow_cc and libtensorflow
WARNING: Exact overlap between lib/libtensorflow_framework.dylib in packages libtensorflow_cc and libtensorflow

Also why are we putting a patch (that conda patches again) into $PREFIX/include? Seems very strange

include/third_party/pybind11_protobuf/0001-Add-Python-include-path.patch (text): Patching

In any case, I wanted to copy the packages, but I haven't managed to run the commands, because I cannot pass through authentication of the anaconda client. I have an account, I double-checked (then updated) my password, I've tried various ways to spell my identity (username/email), and I haven't managed to get through yet.

@hmaarrfk
Copy link
Contributor

hmmm ok i got it to work for me. I use my username

@hmaarrfk hmaarrfk changed the title 2.15.0 with current global pinnings. 2.15.0 for libgrpc159_libprotobuf4244 Dec 22, 2023
@hmaarrfk hmaarrfk merged commit d4e00f0 into conda-forge:main Dec 22, 2023
1 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants