Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build variant for openssl 3 and curl 7 #190

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

Shelnutt2
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This introduce another build variant for openssl 3 with curl 7. We've seen some downstream packages like TileDB-SOMA that pull in other dependencies in a long dependency chain that might need this build variant. @jdblischak has been investigating some resolver issues. I'd like to propose adding this build variant to see if it helps. TileDB packages (like most conda packages) had a combo of curl 7 and openssl 3 previously until the global curl 8 migration took place.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jdblischak
Copy link
Member

All the curl 7 openssl 3 combos failed. Similar to what we're seeing in TileDB-Inc/tiledbsoma-feedstock#24, it appears that libgoogle-cloud/google-cloud-cpp are involved in the solver issue. Looking at the google-cloud-cpp-feedstock, it switched from libcurl 7 to 8 about a month ago, and it stopped building against openssl 1 back in February.

@jdblischak
Copy link
Member

@Shelnutt2 PR #192 was merged after your most recent rebase. Could you please rebase onto main again?

@Shelnutt2 Shelnutt2 merged commit 7d87198 into conda-forge:main Jun 5, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants