Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #32

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add tests #32

wants to merge 8 commits into from

Conversation

bollwyvl
Copy link
Contributor

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Follow-up to #29: adds the tests. While everything is contained in the distributed tarball, they are a little hairy, relying on source files a fair amount, as well as the presence of a fairly large number of dependencies, and require a test skip. But progress nonetheless.

Also, I did all three of the missing test dependencies in one PR, and the queue is a bit backed up to get them made into feedstocks, and this will fail until all of them land, but figured it was worth getting the ball rolling.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 28, 2019 via email

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@bollwyvl bollwyvl closed this Dec 28, 2019
@bollwyvl bollwyvl reopened this Dec 28, 2019
@bollwyvl
Copy link
Contributor Author

Yay green!

Having gotten these working, it's not really that important that we get another build out with the bumped build number: this could be shelved until the next version drops.

@bollwyvl
Copy link
Contributor Author

@conda-forge-admin please rerender

@bollwyvl
Copy link
Contributor Author

There's at least one spurious fail (path-py vs path.py), so we probably need to script/wrap this.

However, some look real, and should be addressed upstream, or further investigated here...

@bollwyvl
Copy link
Contributor Author

Hopefully once conda-forge/tox-feedstock#50 is closed (about to), pip check will work here.. aside from the path-py stuff. sigh.

@bollwyvl bollwyvl closed this Mar 31, 2020
@bollwyvl bollwyvl reopened this Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants