-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build web modules for trame #258
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
The only option that should be needed should be |
But to be clear that GROUP will actually do the same thing as enabling |
I'll leave it up to the maintainers of this feedstock on whether to use the meta Also. The MacOS builds are failing for what looks like an unrelated issue AFAICT |
@conda-forge/vtk, a review would be greatly appreciated so we could get this merged! |
+1 |
Seems like this is missing a runtime dependency on numpy?
|
Hum weirdly enough it seems that no vtk module require numpy while I always thought that it was not optional. $ ack vtk_required_python_modules
CMakeLists.txt
414: get_property(vtk_required_python_modules GLOBAL
415: PROPERTY vtk_required_python_modules)
416: if (vtk_required_python_modules)
417: list(REMOVE_DUPLICATES vtk_required_python_modules)
419: string(REPLACE ";" "\n" vtk_required_python_modules "${vtk_required_python_modules}")
421: "${vtk_required_python_modules}\n")
Rendering/Matplotlib/CMakeLists.txt
19: vtk_required_python_modules "matplotlib>=2.0.0")
Web/Python/CMakeLists.txt
23: vtk_required_python_modules "wslink>=1.0.4") Not sure if we want to add numpy to the list of Web module dependency [Web/Python/CMakeLists.txt]? |
For the sake of this pull request, simply adding numpy to the run requirements should be sufficient. However agreed that fixing it properly upstream will make sense, too. |
I just added I'm thinking |
Unless there are objections, I'm happy to merge if all builds succeeds - will do in ~24 hours. |
Everything that wants it checks for existence first, so there's no requirement. There is the |
@mathstuf - I don't think this is the case. In https://github.com/Kitware/VTK/blob/master/Web/Python/vtkmodules/web/utils.py numpy is imported without checking for existence, and https://github.com/Kitware/VTK/blob/master/Web/Python/CMakeLists.txt does not list numpy as python dependency. |
Good catch. I guess we should wait merging this PR till there is a |
wslink is on it's way: conda-forge/staged-recipes#20806 |
Well, getting code that, when included, assumes |
I've added both |
Sure. I guess they should be in both |
AFAIK, VTK's own build doesn't care about |
Right, but I think it's worth including since I assume almost every user installing VTK from conda is trying to use the Python bindings and numpy dataset interface in https://github.com/Kitware/VTK/blob/f19f9769410a09e5964a217ba33ed58522909eea/Wrapping/Python/vtkmodules/numpy_interface/dataset_adapter.py#L64-L68 etc For the sake of purity, I'm happy to leave these dependencies as |
Further, I'd love for this recipe to move closer to wheel the on PyPI. Both in dependencies and in enabled modules |
I’d be happy to merge this PR as is and deal with the other things in another PR? |
I think we are good for that to be merged as-is for now. Thanks @Tobias-Fischer ! |
I am new at pyvista and vtk and it is hard for me to understand these. Is there an easy way to deal with this problem? |
If install the latest |
It works! Thank you very much. |
So How do I solve this error? I want interactivity inside Jupyter notebooks. I am using VSCode remote.
Looks like it is leading me to this page but installing from conda-forge or PyPI doesn't "just work". @banesullivan |
@shariqfarooq123, please open a new issue in PyVista about this. You'll need to include a pyvista.Report there too |
Thanks very much! |
An experience, just for your information: When I installed PyVista in February 2023 with
And here the informations about the versions :
|
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)This adds the web modules so that this version of VTK is compatible with trame
cc @jourdain