try qt6-main #320

looooo · 2023-12-17T12:15:00Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

…nda-forge-pinning 2023.11.14.16.04.48

conda-forge-webservices · 2023-12-17T12:15:10Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

looooo · 2023-12-24T10:25:24Z

for osx-arm64 add this to the build-script:

if [[ "${target_platform}" =~ osx-arm64 ]]; then
    rm -f "${PREFIX}/lib/qt6/moc"
    ln -s "${BUILD_PREFIX}/lib/qt6/moc" "${PREFIX}/lib/qt6/moc"
    
    # Additional debugging information
    echo "Adjusted Qt tools for osx-arm64 with build variant qt6"
    echo "Removed: ${PREFIX}/lib/qt6/moc"
    echo "Linked to: ${BUILD_PREFIX}/lib/qt6/moc"
else
    echo "Skipping Qt tools adjustment. Target platform: ${target_platform}, Build variant: $build_variant"
fi

osx-64:

ld: framework not found Metal

looooo · 2023-12-25T16:25:31Z

@conda-forge/core build: -skipis here for me not working. any ideas? I would like to keep the build matrix small and only build for py>311
additional the osmesa and egg variants are not needed as these builds are not qt dependent (TODO).

also I would like to know if we can upload with the label qt6 (currently it is set to vtk_qt6) but I guess having a qt6 label is more convenient as this can be used for more packages...

hmaarrfk · 2023-12-25T20:52:22Z

recipe/meta.yaml

@@ -16,7 +16,7 @@
 # otherwise it won't be correct in the final build.

 package:
-  name: vtk
+  name: vtk_qt6


Is it safe to install both vtk and vtk_qt6 at the same time? If not you will need to enforce that with a mutually exclusive package. Is uggest you leave the package name the samr

sorry for the noise on this one, this was the meta package name.

hmaarrfk · 2023-12-25T23:46:42Z

@conda-forge-admin please rerender

conda-forge-webservices · 2023-12-25T23:48:59Z

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

hmaarrfk · 2023-12-25T23:52:47Z

can you rebase and remove the rerendering comits

conda-forge-webservices · 2023-12-26T10:33:01Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

looooo · 2023-12-26T13:42:22Z

@hmaarrfk what do you think about adding a qt6 label to the packages and use a new branch?

hmaarrfk · 2023-12-26T13:44:50Z

why? just rip off the bandaid tbh, it is very confusing to constantly tell people that they need to use a specific label or branch.

If you want to tell people to use a specific label, then you might as well just build our own channel (essentially equivalent) and keep it as updated as you want. It works on a small scale.

I think a better solution would be to update to 9.3 and then users can pin to to 9.2 for "qt5" and "9.3" for qt6.

Qt6, with the exception of qt-webengine, has been doing quite well.

looooo · 2023-12-26T13:59:00Z

why? just rip off the bandaid tbh, it is very confusing to constantly tell people that they need to use a specific label or branch.

I just wanted to not introduce troubles for packages depending on qt5 and vtk. But I am happy to have it directly in conda-forge.

I think a better solution would be to update to 9.3 and then users can pin to to 9.2 for "qt5" and "9.3" for qt6.

sounds good to me.

hmaarrfk · 2023-12-26T15:02:07Z

I don't really know a way to avoid the troubles.

My attempt is to make an easy version cutoff that people that need old can still use.

It is really hard to use build strings for this since build strings are somewhat adhoc

github-actions · 2024-06-01T17:04:58Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/vtk-feedstock/actions/runs/9331856024.

looooo · 2024-06-01T17:23:50Z

@conda-forge/core is this rerendering issue known?

hmaarrfk · 2024-06-01T18:31:31Z

recipe/meta.yaml

@@ -32,13 +32,15 @@ source:
 build:
  number: {{ build }}
  string: {{ build_string }}
+  skip: true  # [py<312]


You really want to skip all but python 3.12???

This line should skip all python versions smaller than 3.12. Just to prevent building the whole build matrix.

this rerendering issue also occurs if I use the conda-forge/main branch of the vtk-feedstock.

yeah i saw some other strange rendering things yesterday... i had to use the bot and not local.

it happens to me on osx-arm, linux-aarch64 and with the bot.

Yeah. I noticed. I don't have a clear answer

conda-smithy 3.32.0 worked for me by not doing the version check. Version 3.33 and 3.34 have this issue.

looooo · 2024-06-02T12:37:07Z

@conda-forge-admin, please rerender

github-actions · 2024-06-02T12:38:38Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/vtk-feedstock/actions/runs/9338304061.

…nda-forge-pinning 2024.06.01.05.54.32

conda-forge-webservices · 2024-06-02T13:33:15Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

In your conda_build_config.yaml, please change the name of MACOSX_DEPLOYMENT_TARGET, to c_stdlib_version!

…nda-forge-pinning 2024.06.01.05.54.32

conda-forge-webservices · 2024-06-02T13:37:15Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

looooo · 2024-06-02T19:50:22Z

ppc64le fails with:

Encountered problems while solving:
  - nothing provides requested proj 9.4.0.*

hmaarrfk · 2024-06-02T20:19:36Z

maybe you have to skip it:
conda-forge/proj.4-feedstock#143

…nda-forge-pinning 2024.06.01.05.54.32

hmaarrfk · 2024-06-02T21:50:28Z

out of curiosity, why do you not want to build ffmpeg 6?

hmaarrfk · 2024-06-02T21:51:10Z

recipe/meta.yaml

@@ -32,13 +32,16 @@ source:
 build:
  number: {{ build }}
  string: {{ build_string }}
+  skip: true  # [py<312]


Suggested change

skip: true # [py<312]

skip: true # [ffmpeg == 6]

skip: true # [py<312]

I think this should skip ffmpeg6 for you, but you should be able to build with both.

looooo · 2024-06-03T18:51:54Z

out of curiosity, why do you not want to build ffmpeg 6?

keep the build-matrix smaller. My goal is to provide freecad builds for qt6. I think it's best to do this first via the anaconda.org freecad organization. I have the fear that qt6 is making things a little bit messy. Or is there a proposal how to deal with qt6 without introducing too much issues for conda-forge?

hmaarrfk · 2024-06-03T18:54:21Z

you can skip it if you want. but ffmpeg7 is quite new, and many projects don't always support it right off the bat.

you can add a skip: true # [ffmpeg == '6'] or something like that and rerender.

or just build the two and forget about it ;)

looooo · 2024-06-03T19:05:00Z

@hmaarrfk I just looked into setting up azure for my personal repo, but I am a bit lost (everything seems to have changed there). What do you think about setting up a qt6 branch for the vtk-feedstock and publish the builds to a qt6-label?

hmaarrfk · 2024-06-03T19:17:04Z

I would not setup a branch unless it has a different version number for VTK.

It increases the chance of a clash.

I've been using qt6 for a while now, i think it is OK.

i would keep it simple for yourself.

Azure kinda broke my personal repo workflow, need time to get it back up and running.

looooo · 2024-06-03T19:21:07Z

@hmaarrfk so there is nothing special needed for qt6 (for example renaming the builds as we did here: https://github.com/conda-forge/soqt-feedstock/blob/main/recipe/meta.yaml#L1L8)?

hmaarrfk · 2024-06-03T19:26:06Z

you added a constraint since the two packages clash:

https://github.com/conda-forge/soqt-feedstock/blob/main/recipe/meta.yaml#L40

OpenCV currently builds 3 variants:

qt5
qt6
noqt

I'm trying to get rid of qt5 given the new version bump (easier to communicate) conda-forge/opencv-feedstock#417

so given that you have a version bump here, might as well only build for qt6 and move on.

…nda-forge-pinning 2024.06.03.19.07.16

looooo · 2024-06-04T07:38:17Z

the osmesa build fails with:

_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include/GL/osmesa.h:323:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'OSMesaPostprocess'

/**
 * Enable/disable Gallium post-process filters.
 * This should be called after a context is created, but before it is
 * made current for the first time.  After a context has been made
 * current, this function has no effect.
 * If the enable_value param is zero, the filter is disabled.  Otherwise
 * the filter is enabled, and the value may control the filter's quality.
 * New in Mesa 10.0
 */
GLAPI void APIENTRY
OSMesaPostprocess(OSMesaContext osmesa, const char *filter,
                  unsigned enable_value);

is there something obvious?

looooo · 2024-06-04T11:28:13Z

@hmaarrfk is it ok to skip the osmesa builds for now?

hmaarrfk · 2024-06-04T11:31:30Z

That's between you and the other maintainers.

Give them a week or two to respond or something?

looooo · 2024-06-07T20:36:58Z

continued in #328

regro-cf-autotick-bot and others added 3 commits November 14, 2023 17:12

updated v9.3.0

6d5bc0e

MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.29.0, and co…

017d519

…nda-forge-pinning 2023.11.14.16.04.48

Add missing fast_float dep

4454188

looooo requested review from Maxyme, Tobias-Fischer, basnijholt, ccordoba12, dfroger, downiec, grlee77, jasonb5, marcelotrevisani, matthiasdiener, msarahan, patricksnape and tadeu as code owners December 17, 2023 12:15

looooo mentioned this pull request Dec 24, 2023

Py312 qt6 conda-forge/freecad-feedstock#117

Closed

5 tasks

hmaarrfk reviewed Dec 25, 2023

View reviewed changes

looooo force-pushed the patch-1 branch from 024064e to 411aa1e Compare December 26, 2023 10:32

hmaarrfk reviewed Jun 1, 2024

View reviewed changes

MNT: Re-rendered with conda-build 24.3.0, conda-smithy 3.32.0, and co…

1ea0567

…nda-forge-pinning 2024.06.01.05.54.32

MNT: Re-rendered with conda-build 24.3.0, conda-smithy 3.32.0, and co…

3ca856e

…nda-forge-pinning 2024.06.01.05.54.32

looooo added 3 commits June 2, 2024 23:38

skip ppc64le

365657c

only build ffmpeg version 7

41c46fd

MNT: Re-rendered with conda-build 24.3.0, conda-smithy 3.32.0, and co…

8e16e1c

…nda-forge-pinning 2024.06.01.05.54.32

hmaarrfk reviewed Jun 2, 2024

View reviewed changes

looooo force-pushed the patch-1 branch from ede657a to 8e16e1c Compare June 3, 2024 19:09

looooo added 2 commits June 3, 2024 22:10

reenable osmesa and egl

bb8419e

MNT: Re-rendered with conda-build 24.3.0, conda-smithy 3.32.0, and co…

ea519a6

…nda-forge-pinning 2024.06.03.19.07.16

looooo closed this Jun 7, 2024

	skip: true # [py<312]
	skip: true # [ffmpeg == 6]
	skip: true # [py<312]

try qt6-main #320

try qt6-main #320

Conversation

looooo commented Dec 17, 2023

conda-forge-webservices bot commented Dec 17, 2023

looooo commented Dec 24, 2023 • edited

looooo commented Dec 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hmaarrfk commented Dec 25, 2023

conda-forge-webservices bot commented Dec 25, 2023

hmaarrfk commented Dec 25, 2023

conda-forge-webservices bot commented Dec 26, 2023

looooo commented Dec 26, 2023

hmaarrfk commented Dec 26, 2023

looooo commented Dec 26, 2023

hmaarrfk commented Dec 26, 2023

github-actions bot commented Jun 1, 2024

looooo commented Jun 1, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

looooo Jun 2, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

looooo commented Jun 2, 2024

github-actions bot commented Jun 2, 2024

conda-forge-webservices bot commented Jun 2, 2024

conda-forge-webservices bot commented Jun 2, 2024

looooo commented Jun 2, 2024

hmaarrfk commented Jun 2, 2024

hmaarrfk commented Jun 2, 2024

Choose a reason for hiding this comment

looooo commented Jun 3, 2024

hmaarrfk commented Jun 3, 2024

looooo commented Jun 3, 2024

hmaarrfk commented Jun 3, 2024

looooo commented Jun 3, 2024

hmaarrfk commented Jun 3, 2024

looooo commented Jun 4, 2024 • edited

looooo commented Jun 4, 2024

hmaarrfk commented Jun 4, 2024

looooo commented Jun 7, 2024

looooo commented Dec 24, 2023 •

edited

looooo commented Jun 1, 2024 •

edited

looooo Jun 2, 2024 •

edited

looooo commented Jun 4, 2024 •

edited