Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try re-enabling OSX (Python 3.x) #34

Closed
wants to merge 4 commits into from

Conversation

patricksnape
Copy link
Contributor

Since Travis now has two cores this might work again (since Ninja automatically builds in parallel)

Since Travis now has two cores this might work again (since Ninja automatically builds in parallel)
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Korijn
Copy link
Contributor

Korijn commented Jun 14, 2017

Would you mind also opening a PR for the second master branch for py27?

@jakirkham
Copy link
Member

Also needs a re-render to get the .travis.yml file back and thus start the Travis CI build.

@patricksnape patricksnape changed the title Try re-enabling OSX Try re-enabling OSX (Python 3.x) Jun 14, 2017
@patricksnape
Copy link
Contributor Author

It's weird, it's like it's even slower with two cores - older builds used to get to the copying phase before running out of time. Although, this does contain the newer OpenGL2 stuff so maybe that is much slower to build?

@Korijn
Copy link
Contributor

Korijn commented Sep 21, 2017

I sure would like to see this thing pass for once... I doubt we can make the build even faster without more trial-and-error fun with cmake parameters... perhaps some Kitware devs could give us advice? Maybe there are some less important groups of VTK modules that we can disable to shave off some build time?

@jakirkham jakirkham mentioned this pull request Sep 21, 2017
@jakirkham
Copy link
Member

jakirkham commented Sep 21, 2017

Went ahead and started a fresh attempt in PR ( #42 ).

Edit: Did this as we have combined Python 2 and Python 3 together in one branch again (and wanted a fresh PR to start 😜). Hope that is ok.

@jakirkham
Copy link
Member

I sure would like to see this thing pass for once... I doubt we can make the build even faster without more trial-and-error fun with cmake parameters...

...or some amazing improvements to ninja. 😄

...perhaps some Kitware devs could give us advice?

Not totally sure who to ask. Maybe @jcfr knows some build tricks. 😉

Maybe there are some less important groups of VTK modules that we can disable to shave off some build time?

That also sounds like a good idea. Though I'm not totally sure what to take out ATM. Seems like you guys have already picked the right things at a basic level. Would have to comb through the docs.


We can probably also shave a minute or so if we cache some stuff like the Miniconda installer, possibly conda packages, etc. Though I don't know how much it will help as that stuff ends up on S3 whether Travis CI caches it or if Continuum provides it. This would be a bit exploratory. Though some work has been done on this front.

@jcfr
Copy link

jcfr commented Sep 21, 2017

knows some build tricks.

Look like you are already disabling testing and examples. You could try to disable MPI related modules.

@jcfr
Copy link

jcfr commented Sep 21, 2017

Also, effort to support building VTK wheels are happening here: https://github.com/jcfr/VTKPythonPackage

We should be able to repackage the vtk wheels into conda packages.

Similarly to what was done for ITK. See [1][2][3]

[1] https://github.com/InsightSoftwareConsortium/ITKPythonPackage
[2] https://blog.kitware.com/itk-is-on-pypi-pip-install-itk-is-here/
[3] https://github.com/conda-forge/itk-feedstock/blob/master/recipe/build.sh

cc: @thewtex

@Korijn
Copy link
Contributor

Korijn commented Oct 17, 2017

Repackaging wheels is definitely something we can look into. We're also considering that approach for https://github.com/conda-forge/wxpython-feedstock

Is the wheel repackaging effort sustainable? E.g. what are the odds of the maintainers stopping their efforts in the future?

@Korijn Korijn closed this Oct 17, 2017
@patricksnape patricksnape deleted the reenable-osx branch October 20, 2017 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants