Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of more recent pybind11 #56

Closed
robertodr opened this issue Oct 24, 2019 · 6 comments · Fixed by #57
Closed

Allow use of more recent pybind11 #56

robertodr opened this issue Oct 24, 2019 · 6 comments · Fixed by #57

Comments

@robertodr
Copy link
Contributor

Issue:
The version of pybind11 is pinned as >=2.1.0,<2.3 but I think any version >=2.1.0 works with xtensor-python. Is it possible to loosen the upperbound?


Environment (conda list): 
$ conda list

Details about conda and system ( conda info ): 
$ conda info
@JohanMabille
Copy link
Contributor

We can give it a try in xtensor-python CI to see if the tests pass. If so, we can update the recipes. Do you want to open the PR?

@robertodr
Copy link
Contributor Author

I'll open a PR modifying the CI YAML. I've been building another project with pybind11 2.3.0 and xtensor-python 0.23.1 without problems.

robertodr added a commit to robertodr/xtensor-python that referenced this issue Oct 24, 2019
@robertodr
Try using pybind11 2.3.0 in CI
712ee44 
Related to conda-forge/xtensor-python-feedstock#56
@robertodr robertodr mentioned this issue Oct 24, 2019
Closed
@robertodr
Copy link
Contributor Author

Should I also try with the latest release (2.4.3)? The upper bound could then be pretty generous (<2.5)

robertodr added a commit to robertodr/xtensor-python that referenced this issue Oct 24, 2019
@robertodr
Use latest pybind11 in CI
fcf2221 
Related to conda-forge/xtensor-python-feedstock#56
@robertodr robertodr mentioned this issue Oct 24, 2019
Merged
@JohanMabille
Copy link
Contributor

Yes I think we can try latest release.

@robertodr
Copy link
Contributor Author

Latest also works. I've updated and re-rendered the recipe

@JohanMabille
Copy link
Contributor

Nice! Thanks for tackling this!

@robertodr robertodr mentioned this issue Oct 26, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow more recent versions of pybind11 robertodr/xtensor-python-feedstock
2 participants
@robertodr @JohanMabille