Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS and JS Linter #34

Closed
3 tasks done
Tracked by #31
travishathaway opened this issue Nov 24, 2022 · 0 comments · Fixed by #35
Closed
3 tasks done
Tracked by #31

Add CSS and JS Linter #34

travishathaway opened this issue Nov 24, 2022 · 0 comments · Fixed by #35
Assignees
@travishathaway
Labels
implementation Issues that deal with the technical implementation of the website
Milestone
First Release

Comments

@travishathaway
Copy link
Contributor

travishathaway commented Nov 24, 2022 •
edited

Description

In order to ensure a consistent coding style, we will add both a CSS and JS linter to our website. This will be run via GitHub actions for each pull request. We will not be using a tool like pre-commit because we want to make it as easy as possible to contribute.

Tasks

  • Decide on JS linter and choose reasonable rules (stick mostly with defaults; check out other projects for inspiration)
  • Decide on CSS linter and choose reasonable rules
  • Add a GitHub action to run these checks for each new pull request
@travishathaway travishathaway added the implementation Issues that deal with the technical implementation of the website label Nov 24, 2022
@travishathaway travishathaway added this to the First Release milestone Nov 24, 2022
@travishathaway travishathaway self-assigned this Nov 24, 2022
@travishathaway travishathaway mentioned this issue Nov 24, 2022
Closed
8 tasks
@travishathaway travishathaway linked a pull request Nov 30, 2022 that will close this issue
Add js and css linters #35
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travishathaway travishathaway

Labels
implementation Issues that deal with the technical implementation of the website
Projects
Conda Dot Org
Status: Timebox: full day plus
Milestone
First Release
Development

Successfully merging a pull request may close this issue.

Add js and css linters conda-incubator/conda-dot-org
1 participant
@travishathaway