New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differential tarball tool #9
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 88.78% 90.36% +1.57%
==========================================
Files 2 3 +1
Lines 312 415 +103
==========================================
+ Hits 277 375 +98
- Misses 35 40 +5
Continue to review full report at Codecov.
|
Ouch, I should probably add some tests. |
@@ -27,7 +27,8 @@ | |||
], | |||
entry_points={ | |||
"console_scripts": [ | |||
'conda-mirror = conda_mirror.conda_mirror:cli' | |||
'conda-mirror = conda_mirror.conda_mirror:cli', | |||
'conda-diff-tar = conda_mirror.diff_tar:main', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be a subcommand of conda-mirror, rather than a separate command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, I realized that just adding the new functionality as options wouldn't make too much sense. Having a sub command it of course possible too, for example conda-mirror diff-tar
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xhochy @mariusvniekerk - any opinions?
Thanks for the feedback @scopatz. I've addressed the points. The only remaining question is how the new functionality should be invoked. First, I though that adding options to the existing |
Thanks @scopatz for suggesting to raise an error and handling it in main. I've made that change, and also added a test for the error being raised in |
Thanks @ilanschnell ! |
I am going to cut a release with this capability |
This PR adds the
conda-diff-tar
command to conda-mirror, a tool for creating tarballs from a previous reference point of a conda repository. The filediff-tar.md
explains all the details.