Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to be able to add dependencies to the wheel #26

Merged
merged 5 commits into from
Sep 5, 2019
Merged

Add option to be able to add dependencies to the wheel #26

merged 5 commits into from
Sep 5, 2019

Conversation

marcelotrevisani
Copy link
Member

Added option --add-deps to be able to add new dependencies to the wheel.

It is also related to #20

cc: @scopatz

@marcelotrevisani marcelotrevisani changed the title Add option to add dependencies to the wheel Add option to be able to add dependencies to the wheel Sep 4, 2019
@scopatz
Copy link
Contributor

scopatz commented Sep 4, 2019

OK, thanks for putting this in! I'll wait until #23 is merged. There seems to be similar issues here too. if you want to fix this PR up as well.

@marcelotrevisani
Copy link
Member Author

OK, thanks for putting this in! I'll wait until #23 is merged. There seems to be similar issues here too. if you want to fix this PR up as well.

Sure, I already applied the same suggestions. thanks!

@marcelotrevisani
Copy link
Member Author

Rebased from master

marcelotrevisani
marcelotrevisani commented Sep 5, 2019
View reviewed changes
.gitignore
@@ -24,6 +24,7 @@ parts/
sdist/
var/
wheels/
.idea/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I'm using PyCharm and the IDE creates this folder to hold their configuration files there, I added it to be excluded from git as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine!

@scopatz
Copy link
Contributor

scopatz commented Sep 5, 2019

This looks good to me; is it ready to merge?

@marcelotrevisani
Copy link
Member Author

This looks good to me; is it ready to merge?

Yes, it is! :)

@scopatz scopatz merged commit 05ea06b into conda-incubator:master Sep 5, 2019
@scopatz
Copy link
Contributor

scopatz commented Sep 5, 2019

Awesome! Should I cut a release with these new features?

@marcelotrevisani
Copy link
Member Author

Awesome! Should I cut a release with these new features?

That would be awesome!

@marcelotrevisani marcelotrevisani deleted the fb-20-add-deps branch September 5, 2019 14:28
@marcelotrevisani marcelotrevisani mentioned this pull request Sep 5, 2019
Closed
@scopatz
Copy link
Contributor

scopatz commented Sep 5, 2019

OK great, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scopatz scopatz scopatz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcelotrevisani @scopatz