Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No metadata #32

Merged
merged 4 commits into from
Sep 13, 2019
Merged

No metadata #32

merged 4 commits into from
Sep 13, 2019

Conversation

scopatz
Copy link
Contributor

@scopatz scopatz commented Sep 13, 2019

@scopatz scopatz mentioned this pull request Sep 13, 2019
Closed
marcelotrevisani
marcelotrevisani reviewed Sep 13, 2019
View reviewed changes
tests/test_condatools.py


def test_xeus_python(pip_install_artifact_tree, xonsh):
wheel, test_env, sp = pip_install_artifact_tree("xeus-python=0.5.1", skip_python=True, fatten=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you verify any of these variables? I mean, the content or something like that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is it a sanity test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more of a sanity test. Previously, the xeus_python wheel wasn't installable at all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is fine then! :)

@SylvainCorlay
Copy link

Thanks for the heads up @scopatz !

@SylvainCorlay
Copy link

cc @JohanMabille @martinRenou

marcelotrevisani
marcelotrevisani approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@marcelotrevisani marcelotrevisani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for fixing it pretty fast! :)

@marcelotrevisani marcelotrevisani merged commit 7d0c176 into master Sep 13, 2019
@scopatz scopatz deleted the nometa branch September 13, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelotrevisani marcelotrevisani marcelotrevisani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scopatz @SylvainCorlay @marcelotrevisani