Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiline strings that don't use > or | characters get interpreted as lists of strings #44

Closed
schuylermartin45 opened this issue May 1, 2024 · 0 comments · Fixed by #68
Closed

Multiline strings that don't use > or | characters get interpreted as lists of strings #44

schuylermartin45 opened this issue May 1, 2024 · 0 comments · Fixed by #68

Comments

@schuylermartin45
Copy link
Collaborator

A summary section like this (found in r-highr-feedstock):

  summary: Provides syntax highlighting for R source code. Currently it supports LaTeX and HTML
    output. Source code of other languages is supported via Andre Simon's highlight
    package (<http://www.andre-simon.de>).

Appears to be valid YAML. The conversion process (or more likely, the parser) turns the above string into:

  summary:
    - Provides syntax highlighting for R source code. Currently it supports LaTeX and HTML
    - "output. Source code of other languages is supported via Andre Simon's highlight"
    - package (<http://www.andre-simon.de>).

^ Which causes rattler-build to fail as the value must be a scalar type for summary.
schuylermartin45 added a commit that referenced this issue May 31, 2024
@schuylermartin45
Adds a first-pass fix to Issue #44
5eccde5
@schuylermartin45 schuylermartin45 mentioned this issue Jun 6, 2024
Merged
schuylermartin45 added a commit that referenced this issue Jun 7, 2024
@schuylermartin45
Multiline summary fix issue 44 (#68)
177b65a 
* Adds some missing build section transforms

* Improves deprecated field system by moving the logic to one function

* Modifies unit tests to handle messaging changes

* Redacts license family from the conda recipe so the conversion build test passes without warnings

* Conversion process will no longer emit an emtpy context object

* Ensures canonical ordering of the Python test element

* Preserves insert-order for patch add ops

* Adds in missing import; caused by bad git parts command

* Makes pre-commit happy

* Adds support for upgrading _most_ `script_env` situations

- The conversion tooling can now upgrade _most_ situations where `script_env`
  is present.
- We cannot easily upgrade scenarios where an environment variable is specified
  with a value with a selector. That will require manual intervention for now

* Adds unit tests for script-env work

* Adds known edge case that is not currently supported into the unit testing to ensure failure is handled correctly

* Adds a fix for recipes that include a hash_type JINJA variable as a key for the sha256 field

* Adds unit tests for hash_type preprocessor replacement

* Adds some pre-processing support for converting functions invoked with a period mark to using the pipe functions supported by rattler-build

* Adds unit tests for dot function support

* Adds a first-pass fix to Issue #44

* Adds unit test for multiline edge case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiline summary fix issue 44 conda-incubator/conda-recipe-manager
1 participant
@schuylermartin45